From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] daemon.c: mark a file-local symbol as static
Date: Sun, 21 Feb 2016 18:25:10 -0500 [thread overview]
Message-ID: <20160221232510.GB4094@sigill.intra.peff.net> (raw)
In-Reply-To: <56C9F4F2.1060100@ramsayjones.plus.com>
On Sun, Feb 21, 2016 at 05:33:38PM +0000, Ramsay Jones wrote:
> If you need to re-roll your 'jk/tighten-alloc' branch, could you
> please squash this into the relevant patch. (ie. "convert manual
> allocations to argv_array").
Thanks, will do. You notice these with sparse, as I recall? I've meant
to look into running that myself, but it looks like we are not
warning-free with sparse currently. I see complaints like:
connect.c:377:40: warning: incorrect type in argument 2 (invalid types)
connect.c:377:40: expected union __CONST_SOCKADDR_ARG [usertype] __addr
connect.c:377:40: got struct sockaddr *ai_addr
As far as I can tell, that's just noise. Do you have a ready-made recipe
for silencing it?
-Peff
next prev parent reply other threads:[~2016-02-21 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 17:33 [PATCH] daemon.c: mark a file-local symbol as static Ramsay Jones
2016-02-21 23:25 ` Jeff King [this message]
2016-02-22 0:33 ` Ramsay Jones
2016-02-22 21:18 ` Jeff King
2016-02-23 0:49 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221232510.GB4094@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).