git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Please document git-http-backend/Apache timeout interactions
Date: Mon, 22 Feb 2016 00:34:27 +0100	[thread overview]
Message-ID: <20160221233427.GA13598@sesse.net> (raw)
In-Reply-To: <xmqqwppx8wwb.fsf@gitster.mtv.corp.google.com>

On Sun, Feb 21, 2016 at 03:29:56PM -0800, Junio C Hamano wrote:
> This feels 70% like "how to configure your Apache server when you
> run site that is contacted by a client that is slow to talk?", that
> is not necessarily specific to Git.

It's specific to Git in the sense that Git seemingly as a normal matter of
course posts very slowly to /git-upload-pack. Normal HTTP clients don't work
this way; they typically have their entire POST body ready before they decide
to make a request.

> Also while it may make sense to tweak the timeout on the server
> side, recommending to disable it altogether, instead of adjusting to
> the typical requirement for a sane client, feels just wrong.

True, although I have no idea what the right limits would be.

> Also, are all requests from one client slow to start, or are only
> some phases in the protocol exchange slow but not others?  If the
> server side can tell which ones could be normally slow, selectively
> loosening timeouts only for them might be more palatable, but I am
> sensing that you are not suggesting such an approach.

I know only of /git-upload-pack having this pattern, and it is the only one I
am seeing 408 errors for in my logs. It seems to fail very rarely (~0.2% of
all /git-upload-pack requests), but for some users, it's seemingly very
persistent.

/* Steinar */
-- 
Homepage: https://www.sesse.net/

      reply	other threads:[~2016-02-21 23:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 22:17 Please document git-http-backend/Apache timeout interactions Steinar H. Gunderson
2016-02-21 23:29 ` Junio C Hamano
2016-02-21 23:34   ` Steinar H. Gunderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221233427.GA13598@sesse.net \
    --to=sgunderson@bigfoot.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).