From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Duy Nguyen <pclouds@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] Correct conditions to free textconv result data
Date: Mon, 22 Feb 2016 18:25:44 -0500 [thread overview]
Message-ID: <20160222232544.GA10362@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqfuwk4a3y.fsf@gitster.mtv.corp.google.com>
On Mon, Feb 22, 2016 at 03:08:01PM -0800, Junio C Hamano wrote:
> > The only thing common in this series is it's the result of
> > -Wwrite-strings. 1/3 changes some "char *" to "const char *", you
> > don't miss anything.
>
> While reading Peff's clarification patch, I did find the assignment
> of "" to the *out pointer disturbing. That part of your patch (I
> presume that is what you mean by the above) may want to be revived.
That part was inherited from diff_populate_filespec, though it casts
explicitly to "char *" since d2543b8 (Clean up diff.c, 2006-06-24).
I guess we could do the same here (not that it makes things any safer,
but at least tells everyone "yes, I _know_ this is weird".
-Peff
next prev parent reply other threads:[~2016-02-22 23:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1456145545-5374-1-git-send-email-pclouds@gmail.com>
2016-02-22 12:52 ` [PATCH 2/3] diff.c: remove unnecessary typecast Nguyễn Thái Ngọc Duy
2016-02-22 12:52 ` [PATCH 3/3] Correct conditions to free textconv result data Nguyễn Thái Ngọc Duy
2016-02-22 13:00 ` Duy Nguyen
2016-02-22 18:06 ` Jeff King
2016-02-22 18:12 ` Jeff King
2016-02-22 23:03 ` Duy Nguyen
2016-02-22 23:08 ` Junio C Hamano
2016-02-22 23:25 ` Jeff King [this message]
2016-02-22 18:28 ` [PATCH] diff: clarify textconv interface Jeff King
2016-02-22 23:01 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222232544.GA10362@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).