From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Jon Griffiths <jon_p_griffiths@yahoo.com>
Subject: [PATCH 3/3] credential-cache--daemon: change to the socket dir on startup
Date: Tue, 23 Feb 2016 02:16:04 -0500 [thread overview]
Message-ID: <20160223071604.GC8395@sigill.intra.peff.net> (raw)
In-Reply-To: <20160223071427.GA7489@sigill.intra.peff.net>
From: Jon Griffiths <jon_p_griffiths@yahoo.com>
Changing to the socket path stops the daemon holding open
the directory the user was in when it was started,
preventing umount from working. We're already holding open a
socket in that directory, so there's no downside.
Thanks-to: Jeff King <peff@peff.net>
Signed-off-by: Jon Griffiths <jon_p_griffiths@yahoo.com>
Signed-off-by: Jeff King <peff@peff.net>
---
credential-cache--daemon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c
index 7cfcd37..776f315 100644
--- a/credential-cache--daemon.c
+++ b/credential-cache--daemon.c
@@ -236,6 +236,14 @@ static void init_socket_directory(const char *path)
if (mkdir(dir, 0700) < 0)
die_errno("unable to mkdir '%s'", dir);
}
+
+ /*
+ * We don't actually care what our cwd is; we chdir here just to
+ * be a friendly daemon and avoid tying up our original cwd.
+ * If this fails, it's OK to just continue without that benefit.
+ */
+ chdir(dir);
+
free(path_copy);
}
--
2.7.2.645.g4e1306c
next prev parent reply other threads:[~2016-02-23 7:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 7:14 [PATCH 0/3] credential-cache: give daemon a predictable cwd Jeff King
2016-02-23 7:15 ` [PATCH 1/3] credential-cache--daemon: refactor check_socket_directory Jeff King
2016-02-23 7:15 ` [PATCH 2/3] credential-cache--daemon: disallow relative socket path Jeff King
2016-02-23 7:16 ` Jeff King [this message]
2016-02-23 21:06 ` [PATCH 3/3] credential-cache--daemon: change to the socket dir on startup Junio C Hamano
2016-02-23 21:07 ` Jeff King
2016-02-23 21:09 ` Junio C Hamano
2016-02-23 21:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223071604.GC8395@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jon_p_griffiths@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).