From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>, git@vger.kernel.org
Subject: Re: [PATCH] push: shorten "push.default is unset" warning message
Date: Wed, 24 Feb 2016 05:11:15 -0500 [thread overview]
Message-ID: <20160224101115.GA20807@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqtwkz1c4b.fsf@gitster.mtv.corp.google.com>
On Tue, Feb 23, 2016 at 11:05:08AM -0800, Junio C Hamano wrote:
> If most people are happy with "simple" (and certainly that was the
> assumption and hope behind the transtion we made at 2.0), we may be
> better off removing the warning altogether. Keeping "and adopt the
> new behaviour" part pretends to be offering a chance to make an
> informed choice, but it will forever be unclear to the non-reader
> what the implication of not adopting the new behaviour is anyway, so
> overall we won't see reduced hits at stackoverflow with this change.
Yeah, this was my first thought on seeing Matthieu's patch. We inserted
that message to tell people about the impending change, and to catch any
stragglers even after the change had happened. At some point it simply
becomes obsolete history.
I dunno if that time is now or not. v2.3.0 (which actually flipped the
switch) is only a year old, but we've been showing the message since
v1.8.0, which is over 3 years old. Even Debian stable is way beyond
that. :)
So my inclination is to just rip out the warning entirely.
-Peff
next prev parent reply other threads:[~2016-02-24 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:59 [PATCH] push: shorten "push.default is unset" warning message Matthieu Moy
2016-02-23 19:05 ` Junio C Hamano
2016-02-23 19:47 ` Matthieu Moy
2016-02-24 10:11 ` Jeff King [this message]
2016-02-23 20:38 ` Philip Oakley
2016-02-23 21:03 ` Matthieu Moy
2016-02-23 21:04 ` [PATCH] Documentation/git-push: document that 'simple' is the default Matthieu Moy
2016-02-25 9:21 ` [PATCH v2 0/2] Remove "push.default unset" warning Matthieu Moy
2016-02-25 9:21 ` [PATCH v2 1/2] push: remove "push.default is unset" warning message Matthieu Moy
2016-02-25 9:22 ` [PATCH v2 2/2] Documentation/git-push: document that 'simple' is the default Matthieu Moy
2016-02-26 10:54 ` [PATCH v2 0/2] Remove "push.default unset" warning Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224101115.GA20807@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).