From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Gabriel Souza Franco <gabrielfrancosouza@gmail.com>
Subject: Re: [PATCH] fetch-pack: fix unadvertised requests validation
Date: Sat, 27 Feb 2016 14:19:44 -0500 [thread overview]
Message-ID: <20160227191943.GD12822@sigill.intra.peff.net> (raw)
In-Reply-To: <20160227190712.GC12822@sigill.intra.peff.net>
On Sat, Feb 27, 2016 at 02:07:12PM -0500, Jeff King wrote:
> We expect whoever creates the "sought" list to fill in the name and sha1
> as appropriate. If that is not happening in some code path, then yeah,
> filter_refs() will not work as intended. But I think the solution there
> would be to fix the caller to set up the "struct ref" more completely.
>
> Gabriel, did this come from a bug you noticed in practice, or was it
> just an intended cleanup?
I double-checked that the code for git-fetch does so. It's in
get_fetch_map()
if (refspec->exact_sha1) {
ref_map = alloc_ref(name);
get_oid_hex(name, &ref_map->old_oid);
} else ...
So we should always have old_oid filled in already, and there is no need
to do so in filter_refs() (and in fact it is wrong, for the degenerate
example I gave earlier).
-Peff
next prev parent reply other threads:[~2016-02-27 19:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 12:43 [PATCH] fetch-pack: fix unadvertised requests validation Gabriel Souza Franco
2016-02-27 18:25 ` Junio C Hamano
2016-02-27 18:32 ` Junio C Hamano
2016-02-27 18:38 ` Junio C Hamano
2016-02-27 19:07 ` Jeff King
2016-02-27 19:19 ` Jeff King [this message]
2016-02-27 20:28 ` Gabriel Souza Franco
2016-02-27 20:32 ` [PATCH] fetch-pack: fix object_id of exact sha1 Gabriel Souza Franco
2016-02-27 22:12 ` Jeff King
2016-02-27 22:23 ` Gabriel Souza Franco
2016-02-28 19:29 ` Junio C Hamano
2016-02-28 22:22 ` [PATCH v2] " Gabriel Souza Franco
2016-02-29 8:30 ` Johannes Schindelin
2016-02-29 10:00 ` Jeff King
2016-03-01 2:08 ` Gabriel Souza Franco
2016-03-01 2:12 ` [PATCH v3] " Gabriel Souza Franco
2016-03-01 4:54 ` Jeff King
2016-03-03 23:35 ` Gabriel Souza Franco
2016-03-04 0:50 ` Jeff King
2016-03-05 1:11 ` [PATCH v4] " Gabriel Souza Franco
2016-03-05 16:59 ` Jeff King
2016-03-05 18:54 ` Junio C Hamano
2016-03-05 19:34 ` [PATCH] fetch-pack: update the documentation for "<refs>..." arguments Gabriel Souza Franco
2016-03-05 19:35 ` Junio C Hamano
2016-03-01 4:40 ` [PATCH v2] fetch-pack: fix object_id of exact sha1 Jeff King
2016-02-29 9:50 ` [PATCH] " Jeff King
2016-02-27 22:08 ` [PATCH] fetch-pack: fix unadvertised requests validation Jeff King
2016-02-28 19:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227191943.GD12822@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=gabrielfrancosouza@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).