git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Guilherme <guibufolo@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git config --get-urlmatch does not set exit code 1 when no match is found
Date: Mon, 29 Feb 2016 06:53:55 -0500	[thread overview]
Message-ID: <20160229115355.GA31273@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMDzUtzNKAYSKYkt3WagkUrA2mKaoDu1rT6Nhf89pXSMg0wZwA@mail.gmail.com>

On Sun, Feb 28, 2016 at 10:09:12AM +0530, Guilherme wrote:

> My current woes are with multi-valued configuration values. More
> specifically credential.helper
> 
> The documentation of git config says that when a value is not matched
> it should return 1.
> 
> To reproduce make sure that credential.helper is not set.
> 
> git config --get-urlmatch credential.helper http://somedomain:1234/
> echo %ERRORLEVEL%
> 0

This isn't really addressing your question, but I should warn you that
internally, the credential code _doesn't_ use the urlmatch
infrastructure. It predates the urlmatch code, and was never converted
(so basically only http.* uses urlmatch).  I think there are some corner
cases where the two behave differently.

I'm not sure what you're using this for, but you may get surprising
results.

-Peff

  parent reply	other threads:[~2016-02-29 11:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-28  4:39 git config --get-urlmatch does not set exit code 1 when no match is found Guilherme
2016-02-28 10:45 ` John Keeping
2016-02-28 11:52   ` John Keeping
2016-02-28 11:54   ` [PATCH 0/3] " John Keeping
2016-02-28 20:01     ` Junio C Hamano
2016-02-28 11:54   ` [PATCH 1/3] config: fail if --get-urlmatch finds no value John Keeping
2016-02-28 11:54   ` [PATCH 2/3] Documentation/git-config: use bulleted list for exit codes John Keeping
2016-02-28 11:54   ` [PATCH 3/3] Documentation/git-config: fix --get-all description John Keeping
2016-02-29 11:53 ` Jeff King [this message]
2016-02-29 13:08   ` git config --get-urlmatch does not set exit code 1 when no match is found Guilherme
2016-03-01 15:03     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160229115355.GA31273@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=guibufolo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).