From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>,
John Keeping <john@keeping.me.uk>
Subject: Re: [PATCH 2/2] Revert "rev-parse: remove restrictions on some options"
Date: Mon, 29 Feb 2016 16:29:43 -0500 [thread overview]
Message-ID: <20160229212943.GA25342@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqy4a3cti1.fsf@gitster.mtv.corp.google.com>
On Mon, Feb 29, 2016 at 09:32:22AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > IOW, I think my 2/2 should be replaced with this:
>
> This looks sensible.
>
> Don't we still want the documentation updates from the previous 2/2?
I don't think so. They were primarily about moving those option blocks
to the "these options must come first..." section, which is no longer
true.
It also added "you don't have to be in a git repository for these" to
that section, but I think that is less important. We could add that
individually to each option, I guess.
-Peff
next prev parent reply other threads:[~2016-02-29 21:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 23:25 [PATCH/RFC 0/2] fix some rev-parse options in non-repos Jeff King
2016-02-26 23:26 ` [PATCH 1/2] t1515: add tests for rev-parse out-of-repo helpers Jeff King
2016-02-26 23:29 ` [PATCH 2/2] Revert "rev-parse: remove restrictions on some options" Jeff King
2016-02-26 23:34 ` Jeff King
2016-02-26 23:44 ` Junio C Hamano
2016-02-27 3:22 ` Jeff King
2016-02-29 11:01 ` Jeff King
2016-02-29 17:32 ` Junio C Hamano
2016-02-29 21:29 ` Jeff King [this message]
2016-02-27 12:25 ` John Keeping
2016-02-29 11:11 ` Jeff King
2016-02-28 0:53 ` Eric Sunshine
2016-02-29 11:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229212943.GA25342@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).