From: Jeff King <peff@peff.net>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: JunioCHamanogitster@pobox.com, Git <git@vger.kernel.org>
Subject: Re: [PATCH] environment.c: introduce DECLARE_GIT_GETTER helper macro
Date: Tue, 1 Mar 2016 10:05:43 -0500 [thread overview]
Message-ID: <20160301150543.GN12887@sigill.intra.peff.net> (raw)
In-Reply-To: <1456601744-18404-1-git-send-email-kuleshovmail@gmail.com>
On Sun, Feb 28, 2016 at 01:35:44AM +0600, Alexander Kuleshov wrote:
> +DECLARE_GIT_GETTER(const char *, get_git_dir, git_dir)
> +DECLARE_GIT_GETTER(const char *, get_git_namespace, namespace)
> +DECLARE_GIT_GETTER(char *, get_object_directory, git_object_dir)
> +DECLARE_GIT_GETTER(char *, get_index_file, git_index_file)
> +DECLARE_GIT_GETTER(char *, get_graft_file, git_graft_file)
Hmm. I'm somewhat lukewarm on this patch. It's fewer lines and less
duplication, which is nice, but this kind of code generation often makes
things annoying (to step into with the debugger, to find with ctags,
etc). I dunno.
-Peff
next prev parent reply other threads:[~2016-03-01 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 19:35 [PATCH] environment.c: introduce DECLARE_GIT_GETTER helper macro Alexander Kuleshov
2016-03-01 15:05 ` Jeff King [this message]
2016-03-01 18:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301150543.GN12887@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=JunioCHamanogitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kuleshovmail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).