From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
David Turner <dturner@twopensource.com>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH 06/10] setup: refactor repo format reading and verification
Date: Thu, 3 Mar 2016 13:28:33 -0500 [thread overview]
Message-ID: <20160303182833.GC24171@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8B6j2AB5CCBVVz7f1JShq0XVicJfzZvjRO54ksde0RMfQ@mail.gmail.com>
On Thu, Mar 03, 2016 at 08:19:22PM +0700, Duy Nguyen wrote:
> On Tue, Mar 1, 2016 at 9:42 PM, Jeff King <peff@peff.net> wrote:
> > - for (i = 0; i < unknown_extensions.nr; i++)
> > - warning("unknown repository extension: %s",
> > - unknown_extensions.items[i].string);
> > - *nongit_ok = -1;
> > - ret = -1;
> > +int verify_repository_format(const struct repository_format *format,
> > + struct strbuf *err)
> > +{
> > + if (GIT_REPO_VERSION_READ < format->version) {
> > + strbuf_addf(err, "Expected git repo version <= %d, found %d",
> > + GIT_REPO_VERSION_READ, format->version);
> > + return -1;
>
> Since you have given lots of thoughts about this code, perhaps just a
> little bit more, double check if these strings should be translatable
> or not and mark _() if so?
I don't see any reason they cannot be. I prefer not to mix it in with
the other changes, though, so I'll do a patch on top.
-Peff
next prev parent reply other threads:[~2016-03-03 18:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 14:35 [PATCH 0/10] cleaning up check_repository_format_gently Jeff King
2016-03-01 14:37 ` [PATCH 01/10] setup: document check_repository_format() Jeff King
2016-03-01 14:38 ` [PATCH 02/10] wrap shared_repository global in get/set accessors Jeff King
2016-03-01 14:39 ` [PATCH 03/10] lazily load core.sharedrepository Jeff King
2016-03-03 13:00 ` Duy Nguyen
2016-03-03 18:23 ` Jeff King
2016-03-01 14:40 ` [PATCH 04/10] check_repository_format_gently: stop using git_config_early Jeff King
2016-03-03 13:08 ` Duy Nguyen
2016-03-03 18:27 ` Jeff King
2016-03-01 14:40 ` [PATCH 05/10] config: drop git_config_early Jeff King
2016-03-01 14:42 ` [PATCH 06/10] setup: refactor repo format reading and verification Jeff King
2016-03-01 21:20 ` David Turner
2016-03-02 2:51 ` Jeff King
2016-03-03 13:19 ` Duy Nguyen
2016-03-03 18:28 ` Jeff King [this message]
2016-03-01 14:43 ` [PATCH 07/10] init: use setup.c's repo version verification Jeff King
2016-03-01 14:45 ` [PATCH 08/10] setup: unify repository version callbacks Jeff King
2016-03-01 14:45 ` [PATCH 09/10] setup: drop repository_format_version global Jeff King
2016-03-01 14:45 ` [PATCH 10/10] setup: drop GIT_REPO_VERSION constants Jeff King
2016-03-02 0:13 ` David Turner
2016-03-02 2:52 ` Jeff King
2016-03-02 0:42 ` [PATCH 0/10] cleaning up check_repository_format_gently David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303182833.GC24171@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).