git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Gabriel Souza Franco <gabrielfrancosouza@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v4] fetch-pack: fix object_id of exact sha1
Date: Sat, 5 Mar 2016 11:59:47 -0500	[thread overview]
Message-ID: <20160305165946.GA23114@sigill.intra.peff.net> (raw)
In-Reply-To: <1457140298-2400-1-git-send-email-gabrielfrancosouza@gmail.com>

On Fri, Mar 04, 2016 at 10:11:38PM -0300, Gabriel Souza Franco wrote:

> Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well,
> 2013-12-05) added support for specifying a SHA-1 as well as a ref name.
> Add support for specifying just a SHA-1 and set the ref name to the same
> value in this case.
> 
> Signed-off-by: Gabriel Souza Franco <gabrielfrancosouza@gmail.com>
> ---
>  Documentation/git-fetch-pack.txt |  4 ++++
>  builtin/fetch-pack.c             | 16 +++++++++++++---
>  t/t5500-fetch-pack.sh            | 14 ++++++++++++++
>  3 files changed, 31 insertions(+), 3 deletions(-)

Thanks, this version looks good to me.

-Peff

  reply	other threads:[~2016-03-05 16:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27 12:43 [PATCH] fetch-pack: fix unadvertised requests validation Gabriel Souza Franco
2016-02-27 18:25 ` Junio C Hamano
2016-02-27 18:32   ` Junio C Hamano
2016-02-27 18:38     ` Junio C Hamano
2016-02-27 19:07   ` Jeff King
2016-02-27 19:19     ` Jeff King
2016-02-27 20:28       ` Gabriel Souza Franco
2016-02-27 20:32         ` [PATCH] fetch-pack: fix object_id of exact sha1 Gabriel Souza Franco
2016-02-27 22:12           ` Jeff King
2016-02-27 22:23             ` Gabriel Souza Franco
2016-02-28 19:29               ` Junio C Hamano
2016-02-28 22:22                 ` [PATCH v2] " Gabriel Souza Franco
2016-02-29  8:30                   ` Johannes Schindelin
2016-02-29 10:00                   ` Jeff King
2016-03-01  2:08                     ` Gabriel Souza Franco
2016-03-01  2:12                       ` [PATCH v3] " Gabriel Souza Franco
2016-03-01  4:54                         ` Jeff King
2016-03-03 23:35                           ` Gabriel Souza Franco
2016-03-04  0:50                             ` Jeff King
2016-03-05  1:11                               ` [PATCH v4] " Gabriel Souza Franco
2016-03-05 16:59                                 ` Jeff King [this message]
2016-03-05 18:54                                   ` Junio C Hamano
2016-03-05 19:34                                     ` [PATCH] fetch-pack: update the documentation for "<refs>..." arguments Gabriel Souza Franco
2016-03-05 19:35                                       ` Junio C Hamano
2016-03-01  4:40                       ` [PATCH v2] fetch-pack: fix object_id of exact sha1 Jeff King
2016-02-29  9:50                 ` [PATCH] " Jeff King
2016-02-27 22:08         ` [PATCH] fetch-pack: fix unadvertised requests validation Jeff King
2016-02-28 19:14     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160305165946.GA23114@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=gabrielfrancosouza@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).