From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] strbuf_getwholeline: NUL-terminate getdelim buffer on error
Date: Sat, 5 Mar 2016 14:36:41 -0500 [thread overview]
Message-ID: <20160305193640.GA20701@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqziucu3d7.fsf@gitster.mtv.corp.google.com>
On Sat, Mar 05, 2016 at 11:33:08AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Not a big rush for 2.8.0-rc, as the bug is in v2.5.0, and I doubt
> > there's an easy trigger besides fast-import. But it might be harmless
> > enough to squeeze in.
>
> Was it found by a real-world debugging session, or by a code
> inspection? I'd be really impressed if it were the latter ;-)
Sorry to disappoint, but it was the former. :)
I found (and am fixing) a _different_ bug with:
{
echo "tag foo"
echo "from HEAD:./bar"
} | git fast-import
and I wondered if fast-import would take:
echo "tag foo from HEAD:./bar"
on one line. The answer is no, btw, but it also tickles this bug (it is
expecting "from ..." on the next line, and handles EOF by detecting the
empty string).
-Peff
prev parent reply other threads:[~2016-03-05 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 18:43 [PATCH] strbuf_getwholeline: NUL-terminate getdelim buffer on error Jeff King
2016-03-05 19:33 ` Junio C Hamano
2016-03-05 19:36 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305193640.GA20701@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).