git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	"Anders Kaseorg" <andersk@mit.edu>,
	gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] rebase -p: avoid grep on potentailly non-ASCII data
Date: Tue, 8 Mar 2016 09:35:56 -0500	[thread overview]
Message-ID: <20160308143556.GA10153@sigill.intra.peff.net> (raw)
In-Reply-To: <56DED770.4050603@drmicha.warpmail.net>

On Tue, Mar 08, 2016 at 02:45:20PM +0100, Michael J Gruber wrote:

> It may be worth noting whether other occurrences of "sane_grep" are safe
> from binary input.
> 
> After all, one my question the degree of sanity of our sane_grep, or
> whether we need asane_grep and bisane_grep in our shell library - "make
> our grep sane again".

I actually wonder if we should have a build-time knob to put "grep -a"
into sane_grep(). We do not ever plan to feed it binary data, so that
will do what, provided the system grep handles "-a". And on those that
do not know about "-a", one imagines that they do not suffer from this
problem in the first place (which is really limited to recent versions
of GNU grep).

-Peff

  reply	other threads:[~2016-03-08 14:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  7:59 [PATCH] rebase -p: avoid grep on potentailly non-ASCII data Anders Kaseorg
2016-03-08 12:25 ` Torsten Bögershausen
2016-03-08 13:45   ` Michael J Gruber
2016-03-08 14:35     ` Jeff King [this message]
2016-03-08 23:20       ` Junio C Hamano
2016-03-08 23:36         ` Junio C Hamano
2016-03-09  0:11           ` Jeff King
2016-03-09  0:10         ` Jeff King
2016-03-09  2:31         ` Anders Kaseorg
2016-03-09 20:26           ` Junio C Hamano
2016-03-10  7:42             ` Torsten Bögershausen
2016-03-10 17:22               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160308143556.GA10153@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=andersk@mit.edu \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).