From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Vadim Zeitlin <vz-git@zeitlins.org>, git@vger.kernel.org
Subject: Re: Possible bug: --ext-diff ignored with --cc in git log
Date: Fri, 11 Mar 2016 13:58:28 -0500 [thread overview]
Message-ID: <20160311185828.GA31750@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqziu4anb9.fsf@gitster.mtv.corp.google.com>
On Fri, Mar 11, 2016 at 10:20:42AM -0800, Junio C Hamano wrote:
> diff --cc foo.sln
> index d7ff46e,6c9aaa1..b829410
> --- a/foo.sln
> +++ b/foo.sln
> @@@ 1,1 @@@
> - d7ff46ec4a016c6ab7d233b9d4a196ecde623528 - generated file
> -6c9aaa1ae63a2255a215c1287e38e75fcc5fc5d3 - generated file
> ++b829410f6da0afc14353b4621d2fdf874181a9f7 - generated file
>
> which would at least tell you that there was a merge, and if the
> merge took the full contents of the file from one of the commits and
> recorded as the result of the merge, then you wouldn't see them in
> the "--cc" output.
>
> It happens that the above is fairly easily doable with today's Git
> without any modification. Here is how.
> [...]
I think an even easier way is:
git log --cc --raw
I know that is somewhat beside the point you are making, which is how we
should handle "--cc" with ext-diff. But I would much rather have us
show nothing for that case, and let the user turn on "--raw", than to
invent a diff-looking format that does not actually represent the file
contents.
-Peff
next prev parent reply other threads:[~2016-03-11 18:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 17:43 Possible bug: --ext-diff ignored with --cc in git log Vadim Zeitlin
2016-03-10 22:33 ` Junio C Hamano
2016-03-11 2:04 ` Re[2]: " Vadim Zeitlin
2016-03-11 18:20 ` Junio C Hamano
2016-03-11 18:58 ` Jeff King [this message]
2016-03-11 19:08 ` Junio C Hamano
2016-03-11 19:45 ` Jeff King
2016-03-12 1:08 ` Re[2]: " Vadim Zeitlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311185828.GA31750@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vz-git@zeitlins.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).