From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: David Turner <dturner@twopensource.com>, pclouds@gmail.com
Subject: [PATCH v2 09/10] setup: drop repository_format_version global
Date: Fri, 11 Mar 2016 17:37:18 -0500 [thread overview]
Message-ID: <20160311223718.GI449@sigill.intra.peff.net> (raw)
In-Reply-To: <20160311223620.GA7963@sigill.intra.peff.net>
Nobody reads this anymore, and they're not likely to; the
interesting thing is whether or not we passed
check_repository_format(), and possibly the individual
"extension" variables.
Signed-off-by: Jeff King <peff@peff.net>
---
cache.h | 1 -
environment.c | 1 -
setup.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/cache.h b/cache.h
index 7704bc6..bec6db5 100644
--- a/cache.h
+++ b/cache.h
@@ -747,7 +747,6 @@ extern int grafts_replace_parents;
*/
#define GIT_REPO_VERSION 0
#define GIT_REPO_VERSION_READ 1
-extern int repository_format_version;
extern int repository_format_precious_objects;
struct repository_format {
diff --git a/environment.c b/environment.c
index 8b8c8e8..d9e3861 100644
--- a/environment.c
+++ b/environment.c
@@ -25,7 +25,6 @@ int log_all_ref_updates = -1; /* unspecified */
int warn_ambiguous_refs = 1;
int warn_on_object_refname_ambiguity = 1;
int ref_paranoia = -1;
-int repository_format_version;
int repository_format_precious_objects;
const char *git_commit_encoding;
const char *git_log_output_encoding;
diff --git a/setup.c b/setup.c
index fbe7ec1..1314c17 100644
--- a/setup.c
+++ b/setup.c
@@ -428,7 +428,6 @@ static int check_repository_format_gently(const char *gitdir, int *nongit_ok)
die("%s", err.buf);
}
- repository_format_version = candidate.version;
repository_format_precious_objects = candidate.precious_objects;
string_list_clear(&candidate.unknown_extensions, 0);
if (!has_common) {
--
2.8.0.rc2.328.g39e2a47
next prev parent reply other threads:[~2016-03-11 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 22:36 [PATCH v2 0/10] cleaning up check_repository_format_gently Jeff King
2016-03-11 22:36 ` [PATCH v2 01/10] setup: document check_repository_format() Jeff King
2016-03-11 22:36 ` [PATCH v2 02/10] wrap shared_repository global in get/set accessors Jeff King
2016-03-11 22:36 ` [PATCH v2 03/10] lazily load core.sharedrepository Jeff King
2016-03-11 22:36 ` [PATCH v2 04/10] check_repository_format_gently: stop using git_config_early Jeff King
2016-03-11 22:37 ` [PATCH v2 05/10] config: drop git_config_early Jeff King
2016-03-11 23:33 ` Junio C Hamano
2016-03-11 22:37 ` [PATCH v2 06/10] setup: refactor repo format reading and verification Jeff King
2016-03-11 22:37 ` [PATCH v2 07/10] init: use setup.c's repo version verification Jeff King
2016-03-11 22:37 ` [PATCH v2 08/10] setup: unify repository version callbacks Jeff King
2016-03-11 22:37 ` Jeff King [this message]
2016-03-11 22:37 ` [PATCH v2 10/10] verify_repository_format: mark messages for translation Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311223718.GI449@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).