From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] clone tests: rename t57* => t56*
Date: Tue, 15 Mar 2016 18:09:03 -0400 [thread overview]
Message-ID: <20160315220903.GA30488@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kZWMhL5kTHU8gdPvm=VqDb58H0ZkNyop=c=P6bLLY1JLg@mail.gmail.com>
On Tue, Mar 15, 2016 at 03:00:09PM -0700, Stefan Beller wrote:
> Talking about ordering, I have two use cases
>
> 1) Before sending out patches: "git rebase -i -x make -x 'make test' <anchor>"
> to catch myself for doing stupid things.
>
> 2) When developing new code, I alternate between running an indivdual test
> "cd t && GIT_TRACE=1 ./t7400... -d -i -x -v " and running prove for all tests
> to have a good check if there are other niches I missed.
Yep, that is roughly my workflow, too (with the occasional "make test &&
make install" thrown in). :)
> So I do not really have strong preference for the right order, I even
> thought about omitting the paragraph from the commit message and
> wanted to put it into the notes below, but then I figured I want to
> record it as I was frustrated about the commit messages from 2006 as
> they don't answer simple questions like "Why did you use a different
> second digit?", so I figured if anyone digs up my commit eventually I
> want to record as much of my current reasoning even if it is minor to
> help a future developer?
I agree it is worth mentioning that you considered the order. I think
what you wrote was fine, though I probably would have said something
like:
Moving t57* to higher digits in t56* preserves the existing ordering.
That may or may not matter to anyone, but it does not hurt to keep it.
-Peff
prev parent reply other threads:[~2016-03-15 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 21:25 [PATCH] clone tests: rename t57* => t56* Stefan Beller
2016-03-15 21:51 ` Jeff King
2016-03-15 22:00 ` Stefan Beller
2016-03-15 22:09 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315220903.GA30488@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).