From: Jeff King <peff@peff.net>
To: Anton Wuerfel <anton.wuerfel@fau.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Phillip@i4.informatik.uni-erlangen.de, i4passt@cs.fau.de,
git@vger.kernel.org
Subject: Re: [PATCH 0/1] http: Fix crash when passing malformed URL
Date: Wed, 16 Mar 2016 17:29:38 -0400 [thread overview]
Message-ID: <20160316212938.GA4441@sigill.intra.peff.net> (raw)
In-Reply-To: <1458125647-32707-1-git-send-email-anton.wuerfel@fau.de>
On Wed, Mar 16, 2016 at 11:54:06AM +0100, Anton Wuerfel wrote:
> When passing a malformed URL to http_init() in http.c, git dies from a null
> pointer dereference. An example for a malformed URL is http:/git-scm.com (note
> the single slash after the protocol).
>
> I could not reproduce this error within any functions of git - I just noticed it
> during development of a git extension together with Phillip Raffeck.
You can reproduce it with:
git clone https::bogus
Normally we recognize "https://" as the signal to send the URL to the
git-remote-https helper, but you can override the helper by specifying
"whatever::", and then the rest of the string will be passed to it.
-Peff
prev parent reply other threads:[~2016-03-16 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 10:54 [PATCH 0/1] http: Fix crash when passing malformed URL Anton Wuerfel
2016-03-16 10:54 ` [PATCH 1/1] " Anton Wuerfel
2016-03-16 21:42 ` Jeff King
2016-03-16 21:29 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316212938.GA4441@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Phillip@i4.informatik.uni-erlangen.de \
--cc=anton.wuerfel@fau.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=i4passt@cs.fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).