From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH][Outreachy] branch: allow - as abbreviation of '@{-1}'
Date: Sat, 19 Mar 2016 02:02:55 +0900 [thread overview]
Message-ID: <20160318170255.GA9846@glandium.org> (raw)
In-Reply-To: <xmqqvb4jrcle.fsf@gitster.mtv.corp.google.com>
On Fri, Mar 18, 2016 at 09:10:37AM -0700, Junio C Hamano wrote:
> * We forbid declaration-after-statement in our codebase.
By the way, why not enforce it with -Werror=declaration-after-statement?
If people patching git get an error when they do it, they won't submit
a patch with it, and you won't have to tell them about it :)
Mike
next prev parent reply other threads:[~2016-03-18 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 12:47 [PATCH][Outreachy] branch: allow - as abbreviation of '@{-1}' Elena Petrashen
2016-03-18 16:10 ` Junio C Hamano
2016-03-18 17:02 ` Mike Hommey [this message]
2016-03-18 18:15 ` Eric Sunshine
2016-03-18 18:13 ` Eric Sunshine
2016-03-21 15:12 ` elena petrashen
2016-03-21 16:03 ` Eric Sunshine
2016-03-21 16:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318170255.GA9846@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).