From: Paul Mackerras <paulus@ozlabs.org>
To: Rogier Goossens <goossens.rogier@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] gitk: Add a 'rename' option to the branch context menu
Date: Sat, 19 Mar 2016 14:45:55 +1100 [thread overview]
Message-ID: <20160319034555.GB27126@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <1859807.50qitjY8Ul@wiske>
On Fri, Jan 15, 2016 at 10:38:49PM +0100, Rogier Goossens wrote:
>
> Signed-off-by: Rogier Goossens <goossens.rogier@gmail.com>
This is a nice idea; I just have some comments about the Tcl here:
> @@ -9756,15 +9831,19 @@ proc headmenu {x y id head} {
> stopfinding
> set headmenuid $id
> set headmenuhead $head
> - set state normal
> + array set state {0 normal 1 normal 2 normal 3 normal}
> if {[string match "remotes/*" $head]} {
> - set state disabled
> + set state(0) disabled
> + set state(1) disabled
> + set state(2) disabled
Why not "array set state {0 disabled 1 disabled 2 disabled}" instead?
> }
> if {$head eq $mainhead} {
> - set state disabled
> + set state(0) disabled
> + set state(1) disabled
Similarly, "array set state {0 disabled 1 disabled}".
> + }
> + foreach i {0 1 2 3} {
Why do you go up to 3 when we never disable the 3rd entry?
Paul.
next prev parent reply other threads:[~2016-03-19 7:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 21:31 [PATCH 0/2] gitk: Two improvements to the branch context menu Rogier Goossens
2016-01-15 21:38 ` [PATCH 1/2] gitk: Add a 'rename' option " Rogier Goossens
2016-03-19 3:45 ` Paul Mackerras [this message]
2016-01-15 21:43 ` [PATCH 2/2] gitk: Allow checking out a remote branch Rogier Goossens
2016-03-19 18:31 ` [PATCH v2 0/2] gitk: Two improvements to the branch context menu Rogier Goossens
2016-03-19 18:32 ` [PATCH 1/2] gitk: Add a 'rename' option " Rogier Goossens
2016-03-19 18:33 ` [PATCH 2/2] gitk: Allow checking out a remote branch Rogier Goossens
2016-03-27 7:21 ` [PATCH v2a 3/3] gitk: Include commit title in branch dialog Rogier Goossens
2016-12-12 0:02 ` [PATCH v2 0/2] gitk: Two improvements to the branch context menu Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160319034555.GB27126@fergus.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=git@vger.kernel.org \
--cc=goossens.rogier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).