From: Jeff King <peff@peff.net>
To: Laurent Arnoud <laurent@spkdev.net>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Add the tag.gpgsign option to sign all created tags
Date: Sun, 20 Mar 2016 12:52:17 -0400 [thread overview]
Message-ID: <20160320165216.GA5710@sigill.intra.peff.net> (raw)
In-Reply-To: <20160320122023.GA5139@spk-laptop>
On Sun, Mar 20, 2016 at 01:20:23PM +0100, Laurent Arnoud wrote:
> Hi Jeff,
>
> On Sun, Mar 20, 2016 at 12:29:12AM -0400, Jeff King wrote:
> > We have commit.gpgsign, so this makes some sense. Would you want to sign
> > _all_ tags created with "git tag", including lightweight tags, or only
> > those that would already create a tag object (i.e., annotated tags)?
>
> Yes those that create a tag object (annotated tags).
> All you suggestions make sense and I will prepare a patch v2.
That behavior makes more sense to me, but I don't think it's what your
patch does (v1 or v2). Perhaps it would make sense to add some tests,
both to verify that it is behaving as expected, and to protect that
behavior from future changes?
-Peff
next prev parent reply other threads:[~2016-03-20 16:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 18:23 [PATCH] Add the tag.gpgsign option to sign all created tags Laurent Arnoud
2016-03-20 4:29 ` Jeff King
2016-03-20 12:20 ` Laurent Arnoud
2016-03-20 16:52 ` Jeff King [this message]
2016-03-20 17:44 ` Laurent Arnoud
2016-03-20 15:07 ` [PATCH v2] " Laurent Arnoud
2016-03-20 16:38 ` Ramsay Jones
2016-03-21 5:50 ` Junio C Hamano
2016-03-21 19:29 ` Laurent Arnoud
2016-03-21 19:43 ` Junio C Hamano
2016-03-21 20:01 ` Laurent Arnoud
2016-03-21 20:04 ` Jeff King
2016-03-21 20:50 ` [PATCH v4] Add the tag.gpgsign option to sign annotated tags Laurent Arnoud
2016-03-21 21:26 ` Junio C Hamano
2016-03-22 19:36 ` [PATCH v5] Add the option to force " Laurent Arnoud
2016-03-22 19:48 ` Junio C Hamano
2016-03-22 20:07 ` Laurent Arnoud
2016-03-22 20:41 ` [PATCH v6] " Laurent Arnoud
2016-03-21 22:06 ` [PATCH v2] Add the tag.gpgsign option to sign all created tags Junio C Hamano
2016-03-21 19:32 ` [PATCH v3] Add the tag.gpgsign option to sign annotated tags Laurent Arnoud
2016-03-21 19:42 ` Jeff King
2016-03-21 19:53 ` [PATCH v2] Add the tag.gpgsign option to sign all created tags Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160320165216.GA5710@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=laurent@spkdev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).