From: Josh Triplett <josh@joshtriplett.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: Properties of trees referencing commit objects (mode 160000)?
Date: Sun, 20 Mar 2016 15:43:01 -0700 [thread overview]
Message-ID: <20160320224301.GA20803@x> (raw)
In-Reply-To: <xmqqk2kwok8s.fsf@gitster.mtv.corp.google.com>
On Sun, Mar 20, 2016 at 03:30:27PM -0700, Junio C Hamano wrote:
> Josh Triplett <josh@joshtriplett.org> writes:
>
> > On Sun, Mar 20, 2016 at 12:18:04AM -0400, Jeff King wrote:
> >> On Sat, Mar 19, 2016 at 03:13:48PM -0700, Josh Triplett wrote:
> >>
> >> > I'm building some tools to track commit objects, and I'm thinking of
> >> > using submodule-style references to commit objects in tree objects (mode
> >> > 160000) to do so. I'm trying to figure out some of the properties of
> >> > that.
> >> >
> >> > Can a commit object referenced that way live in the same repository,
> >> > rather than some external repository?
> >>
> >> Yes, it can be in the same repository, but...
> >
> > Will git clone/checkout/etc handle it properly in that case, in the
> > absence of a .gitmodules file? Or would it only work with custom tools?
>
> That depends on the definition of "proper". The default "proper"
> way for the core Git for submodules/gitlinks is to create an empty
> directory. If you want to populate a working tree for that, you'd
> need "git submodule" support, but because you are writing "some
> tools" on your own, there probably is a reason why you do not want
> to use "git submodule", so I am guessing that your definition of
> "proper" does not match either core Git or "git submodule" considers
> "proper"? In which case you would need to implement your own
> semantics (you may not even want to have an empty directory there,
> for example).
I can live with "creates an empty directory and doesn't choke or
complain". I'd kinda hoped that git might notice it already has the
commit, and do something like checking out the files of that commit into
the working directory, but it isn't critical.
- Josh Triplett
prev parent reply other threads:[~2016-03-20 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 22:13 Properties of trees referencing commit objects (mode 160000)? Josh Triplett
2016-03-20 4:18 ` Jeff King
2016-03-20 18:45 ` Josh Triplett
2016-03-20 20:07 ` Jeff King
2016-03-20 23:22 ` Josh Triplett
2016-03-21 5:57 ` Jeff King
2016-03-21 15:36 ` Josh Triplett
2016-03-20 22:30 ` Junio C Hamano
2016-03-20 22:43 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160320224301.GA20803@x \
--to=josh@joshtriplett.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).