git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Laurent Arnoud <laurent@spkdev.net>, git@vger.kernel.org
Subject: Re: [PATCH v2] Add the tag.gpgsign option to sign all created tags
Date: Mon, 21 Mar 2016 16:04:51 -0400	[thread overview]
Message-ID: <20160321200451.GA32071@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqvb4fliq6.fsf@gitster.mtv.corp.google.com>

On Mon, Mar 21, 2016 at 12:43:45PM -0700, Junio C Hamano wrote:

> If so, then the configuration is "when the user gives us a message
> to create a tag without explicitly saying -a/-s, we create an
> annotated tag by default, but create a signed tag instead in such a
> case", I would think.  That is:
> 
>     $ git tag -m 'foo' $tagname
> 
> would create signed tag under such a configuration option, and I
> think such an option may make sense.  And the way to override it
> would be
> 
>     $ git tag -a -m 'foo' $tagname
> 
> So there is no need for --no-sign option.  When the user explicitly
> asks to create an annotated tag with
> 
>     $ git tag -a -m 'foo' $tagname
> 
> it is unreasonable to override that explicit wish with a
> configuration setting.

FWIW, of the schemes discussed in this thread, this one makes the most
sense to me (and is one I might actually use).

I think you could shoe-horn it into my "tag-type" config scheme as a new
mode ("sign-if-message" or something), but I think it is much clearer as
a standalone config variable.

Thanks for a dose of sanity.

-Peff

  parent reply	other threads:[~2016-03-21 20:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-19 18:23 [PATCH] Add the tag.gpgsign option to sign all created tags Laurent Arnoud
2016-03-20  4:29 ` Jeff King
2016-03-20 12:20   ` Laurent Arnoud
2016-03-20 16:52     ` Jeff King
2016-03-20 17:44       ` Laurent Arnoud
2016-03-20 15:07   ` [PATCH v2] " Laurent Arnoud
2016-03-20 16:38     ` Ramsay Jones
2016-03-21  5:50     ` Junio C Hamano
2016-03-21 19:29       ` Laurent Arnoud
2016-03-21 19:43         ` Junio C Hamano
2016-03-21 20:01           ` Laurent Arnoud
2016-03-21 20:04           ` Jeff King [this message]
2016-03-21 20:50           ` [PATCH v4] Add the tag.gpgsign option to sign annotated tags Laurent Arnoud
2016-03-21 21:26             ` Junio C Hamano
2016-03-22 19:36               ` [PATCH v5] Add the option to force " Laurent Arnoud
2016-03-22 19:48                 ` Junio C Hamano
2016-03-22 20:07                   ` Laurent Arnoud
2016-03-22 20:41                   ` [PATCH v6] " Laurent Arnoud
2016-03-21 22:06           ` [PATCH v2] Add the tag.gpgsign option to sign all created tags Junio C Hamano
2016-03-21 19:32       ` [PATCH v3] Add the tag.gpgsign option to sign annotated tags Laurent Arnoud
2016-03-21 19:42         ` Jeff King
2016-03-21 19:53       ` [PATCH v2] Add the tag.gpgsign option to sign all created tags Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321200451.GA32071@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=laurent@spkdev.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).