git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Thomas Adam <thomas.adam22@gmail.com>
Cc: git list <git@vger.kernel.org>
Subject: Re: When does git check for branch-X being uptodate with origin/branch-X?
Date: Mon, 21 Mar 2016 17:18:34 -0400	[thread overview]
Message-ID: <20160321211834.GA1068@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+39Oz51SaKAWsJ027fzhR3CRDfqmy1Dp7qcpx-k9-HrzGKcwg@mail.gmail.com>

On Mon, Mar 21, 2016 at 09:12:18PM +0000, Thomas Adam wrote:

> On 21 March 2016 at 20:50, Jeff King <peff@peff.net> wrote:
> > But that's just my opinion. Did you have some specific change you're
> > interested in? I don't think removing that message is productive; it
> > _is_ useful information. Perhaps it could be more clear that we are
> > talking about the tracking branch?
> 
> I don't have a specific change in mind per-se, rather than to discuss
> how we might be able to improve the error message, or document
> somewhere that it's referring to the tracking branch.  Maybe that's
> the point--is it worth mentioning the time/date of when the cache was
> last updated?  That is:
> 
> "branch-X is uptodate with origin/branch-X (as of DD-MM-YY HH:MM:SS)"

Again, just my opinion, but that looks awfully clunky. And it doesn't
address the other messages (you might be behind origin/branch-X by N
commits, or ahead by N, but only as of that particular date). Do we want
to annotate every message whose value was computed based on a tracking
branch?

> No one's suggesting that this message is removed, I'm not sure where
> you got that from?

You said earlier:

> [...]it's more a case of whether even printing that message is useful?

I didn't know quite what you had in mind, which is why I asked. If we
all agree that removing it is a bad idea, then good, we don't have to
bother discussing that option. :)

-Peff

  reply	other threads:[~2016-03-21 21:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 20:21 When does git check for branch-X being uptodate with origin/branch-X? Thomas Adam
2016-03-21 20:28 ` Jeff King
2016-03-21 20:43   ` Thomas Adam
2016-03-21 20:47     ` Junio C Hamano
2016-03-21 20:50     ` Jeff King
2016-03-21 21:12       ` Thomas Adam
2016-03-21 21:18         ` Jeff King [this message]
2016-03-21 21:22           ` Thomas Adam
2016-03-21 21:50         ` Stefan Beller
2016-03-21 21:57           ` Junio C Hamano
2016-03-21 22:11             ` Stefan Beller
2016-03-21 22:42               ` Junio C Hamano
2016-03-21 23:18                 ` Stefan Beller
2016-03-22 17:51     ` Philip Oakley
2016-03-21 20:48   ` Stefan Beller
2016-03-21 20:52   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321211834.GA1068@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=thomas.adam22@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).