From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Thomas Rast <tr@thomasrast.ch>
Subject: Re: [RFC/PATCH] t/perf: "make clean" from the top-level to clean results
Date: Mon, 28 Mar 2016 16:20:42 -0400 [thread overview]
Message-ID: <20160328202042.GA23792@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqfuvaxsr1.fsf@gitster.mtv.corp.google.com>
On Mon, Mar 28, 2016 at 01:16:50PM -0700, Junio C Hamano wrote:
> Running "make clean" from the top-level after running perf tests
> left t/perf/test-results/ directory and tons of files in it. At
> least "make distclean" should turn things back to pristine state.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
> * Perhaps I am missing some reason why this was deliberately left
> out when we added t/perf/Makefile that does have the clean
> target? Cc'ing the suspects found by "shortlog t/perf".
I don't think I've ever touched the "clean" code path.
This change is fine by me. I have noticed that the contents of
t/perf/build can pile up and consume quite a lot of space, as they are
all full builds of git. They're a little more expensive to reproduce
than some other things, but they're inherently still a cache. I think
your patch is doing the right thing.
-Peff
next prev parent reply other threads:[~2016-03-28 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 20:16 [RFC/PATCH] t/perf: "make clean" from the top-level to clean results Junio C Hamano
2016-03-28 20:20 ` Jeff King [this message]
2016-03-29 10:44 ` [RFC/PATCH] t/perf: Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328202042.GA23792@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).