* [RFC/PATCH] t/perf: "make clean" from the top-level to clean results @ 2016-03-28 20:16 Junio C Hamano 2016-03-28 20:20 ` Jeff King 2016-03-29 10:44 ` [RFC/PATCH] t/perf: Beat Bolli 0 siblings, 2 replies; 3+ messages in thread From: Junio C Hamano @ 2016-03-28 20:16 UTC (permalink / raw) To: git; +Cc: Thomas Rast, Jeff King Running "make clean" from the top-level after running perf tests left t/perf/test-results/ directory and tons of files in it. At least "make distclean" should turn things back to pristine state. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * Perhaps I am missing some reason why this was deliberately left out when we added t/perf/Makefile that does have the clean target? Cc'ing the suspects found by "shortlog t/perf". t/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/t/Makefile b/t/Makefile index 18e2b28..e0aef9a 100644 --- a/t/Makefile +++ b/t/Makefile @@ -48,6 +48,7 @@ pre-clean: clean-except-prove-cache: $(RM) -r 'trash directory'.* '$(TEST_RESULTS_DIRECTORY_SQ)' $(RM) -r valgrind/bin + cd perf && $(MAKE) clean clean: clean-except-prove-cache $(RM) .prove ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC/PATCH] t/perf: "make clean" from the top-level to clean results 2016-03-28 20:16 [RFC/PATCH] t/perf: "make clean" from the top-level to clean results Junio C Hamano @ 2016-03-28 20:20 ` Jeff King 2016-03-29 10:44 ` [RFC/PATCH] t/perf: Beat Bolli 1 sibling, 0 replies; 3+ messages in thread From: Jeff King @ 2016-03-28 20:20 UTC (permalink / raw) To: Junio C Hamano; +Cc: git, Thomas Rast On Mon, Mar 28, 2016 at 01:16:50PM -0700, Junio C Hamano wrote: > Running "make clean" from the top-level after running perf tests > left t/perf/test-results/ directory and tons of files in it. At > least "make distclean" should turn things back to pristine state. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > > * Perhaps I am missing some reason why this was deliberately left > out when we added t/perf/Makefile that does have the clean > target? Cc'ing the suspects found by "shortlog t/perf". I don't think I've ever touched the "clean" code path. This change is fine by me. I have noticed that the contents of t/perf/build can pile up and consume quite a lot of space, as they are all full builds of git. They're a little more expensive to reproduce than some other things, but they're inherently still a cache. I think your patch is doing the right thing. -Peff ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC/PATCH] t/perf: 2016-03-28 20:16 [RFC/PATCH] t/perf: "make clean" from the top-level to clean results Junio C Hamano 2016-03-28 20:20 ` Jeff King @ 2016-03-29 10:44 ` Beat Bolli 1 sibling, 0 replies; 3+ messages in thread From: Beat Bolli @ 2016-03-29 10:44 UTC (permalink / raw) To: git Junio C Hamano <gitster <at> pobox.com> writes: > + cd perf && $(MAKE) clean I think the clean way to do this is $(make) -C perf clean Regards, Beat ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-29 12:00 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-28 20:16 [RFC/PATCH] t/perf: "make clean" from the top-level to clean results Junio C Hamano 2016-03-28 20:20 ` Jeff King 2016-03-29 10:44 ` [RFC/PATCH] t/perf: Beat Bolli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).