From: Miklos Vajna <vmiklos@collabora.co.uk>
To: git@vger.kernel.org
Subject: Signed-off-by vs Reviewed-by
Date: Thu, 31 Mar 2016 14:35:07 +0200 [thread overview]
Message-ID: <20160331123507.GC19857@collabora.co.uk> (raw)
Hi,
Some projects like LibreOffice don't use Signed-off-by, instead usually
use Gerrit for code review, and reviewers add a Reviewed-by line when
they are OK with a patch. In this workflow it's a bit unfortunate that
adding a Signed-off-by line is just a command-line switch, but adding a
Reviewed-by line is more complex.
Is there anything in git that could help this situation? I didn't see
any related config option; I wonder if a patch would be accepted to make
the "Signed-off-by" line configurable, or there is a better way.
Like, would a patch that adds e.g. a core.signedOffString configuration
option to make the string customizable welcome?
Thanks,
Miklos
next reply other threads:[~2016-03-31 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 12:35 Miklos Vajna [this message]
2016-03-31 14:24 ` Signed-off-by vs Reviewed-by Pranit Bauva
2016-03-31 14:35 ` Miklos Vajna
2016-03-31 14:57 ` Sidhant Sharma
2016-03-31 15:09 ` Christian Couder
2016-03-31 16:28 ` Junio C Hamano
2016-03-31 17:21 ` Jeff King
2016-03-31 17:23 ` Junio C Hamano
2016-04-01 14:10 ` Miklos Vajna
2016-03-31 14:32 ` Jeff King
2016-03-31 15:02 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331123507.GC19857@collabora.co.uk \
--to=vmiklos@collabora.co.uk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).