From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miklos Vajna Subject: Re: Signed-off-by vs Reviewed-by Date: Thu, 31 Mar 2016 16:35:02 +0200 Message-ID: <20160331143501.GE19857@collabora.co.uk> References: <20160331123507.GC19857@collabora.co.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="osDK9TLjxFScVI/L" Cc: Git List To: Pranit Bauva X-From: git-owner@vger.kernel.org Thu Mar 31 16:35:16 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aldgo-0008N7-59 for gcvg-git-2@plane.gmane.org; Thu, 31 Mar 2016 16:35:14 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756543AbcCaOfI (ORCPT ); Thu, 31 Mar 2016 10:35:08 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:48173 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbcCaOfI (ORCPT ); Thu, 31 Mar 2016 10:35:08 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: vmiklos) with ESMTPSA id 5CBE32613C4 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: --osDK9TLjxFScVI/L Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi, On Thu, Mar 31, 2016 at 07:54:47PM +0530, Pranit Bauva wrote: > Are you suggesting to use a different email address for commiting, > signing off and reviewing? Let's say project A has a workflow where patch authors and maintainers add a "Signed-off-by: A B " line. This is well-supported by git, various commands have a -s option to add that line. However, if project B has a workflow where patch authors add no such line, and reviewers add a "Reviewed-by: A B " line, then you have to add that line manually when you do a review. I suggest to give a bit more support to this workflow in git. One way of doing that would be to make the Signed-off-by string configurable. I can look into implementing that, but first I wanted to discuss the idea here on the list -- perhaps there is a better way to support that. :-) Typing that line (including copy&pasting your name + email all the time) is a bit boring. Regards, Miklos --osDK9TLjxFScVI/L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlb9NZUACgkQe81tAgORUJbQBACeOdi99as1JuNMnvGtzh9D7v36 c/YAn2l9HHh4MaiZ3GlFkOeuZlFObVcd =NDU2 -----END PGP SIGNATURE----- --osDK9TLjxFScVI/L--