git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, dborowitz@google.com, stanislav@assembla.com
Subject: Re: [PATCH v4] git-send-pack: fix --all option when used with directory
Date: Thu, 31 Mar 2016 19:26:23 -0400	[thread overview]
Message-ID: <20160331232623.GA6120@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqoa9ul30c.fsf@gitster.mtv.corp.google.com>

On Thu, Mar 31, 2016 at 03:02:43PM -0700, Junio C Hamano wrote:

> By the way, for some reason it was unusually painful to find the
> exact breakage by bisecting between maint-2.4 and maint-2.6.  It
> somehow ended up on fingering random places like v2.6.0 itself.
> 
> The true culprit is 068c77a5 (builtin/send-pack.c: use parse_options
> API, 2015-08-19).  I didn't dug deep enough to tell if we recently
> broke "git bisect" or if there are something wrong in the shape of
> my history.

Weird. I bisected this when v1 was published, and didn't have any
trouble. I guess it's possible I just got lucky in where I landed,
though, if I started at different endpoints than you.

-Peff

  parent reply	other threads:[~2016-03-31 23:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 13:55 [PATCH v4] git-send-pack: fix --all option when used with directory stanislav
2016-03-31 20:28 ` Junio C Hamano
2016-03-31 22:02   ` Junio C Hamano
2016-03-31 22:55     ` Eric Sunshine
2016-03-31 23:26     ` Jeff King [this message]
2016-04-01 10:44   ` Stanislav Kolotinskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331232623.GA6120@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=dborowitz@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stanislav@assembla.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).