git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] send-email: do not load Data::Dumper
Date: Wed, 6 Apr 2016 14:07:32 -0700	[thread overview]
Message-ID: <20160406210706.GK28749@google.com> (raw)
In-Reply-To: <20160406202538.GA27651@dcvr.yhbt.net>

Eric Wong wrote:

> We never used Data::Dumper in this script.  The only reference
> of it was always commented out and removed over a decade ago in
> commit 4bc87a28be020a6bf7387161c65ea3d8e4a0228b
> ("send-email: Change from Mail::Sendmail to Net::SMTP")
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>  While I'm in the area...
>
>  git-send-email.perl | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

      reply	other threads:[~2016-04-06 21:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 20:25 [PATCH] send-email: do not load Data::Dumper Eric Wong
2016-04-06 21:07 ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406210706.GK28749@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).