* [PATCH] send-email: do not load Data::Dumper
@ 2016-04-06 20:25 Eric Wong
2016-04-06 21:07 ` Jonathan Nieder
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2016-04-06 20:25 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
We never used Data::Dumper in this script. The only reference
of it was always commented out and removed over a decade ago in
commit 4bc87a28be020a6bf7387161c65ea3d8e4a0228b
("send-email: Change from Mail::Sendmail to Net::SMTP")
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
While I'm in the area...
git-send-email.perl | 1 -
1 file changed, 1 deletion(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 52cf828..38f0a7e 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -23,7 +23,6 @@ use POSIX qw/strftime/;
use Term::ReadLine;
use Getopt::Long;
use Text::ParseWords;
-use Data::Dumper;
use Term::ANSIColor;
use File::Temp qw/ tempdir tempfile /;
use File::Spec::Functions qw(catfile);
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] send-email: do not load Data::Dumper
2016-04-06 20:25 [PATCH] send-email: do not load Data::Dumper Eric Wong
@ 2016-04-06 21:07 ` Jonathan Nieder
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2016-04-06 21:07 UTC (permalink / raw)
To: Eric Wong; +Cc: Junio C Hamano, git
Eric Wong wrote:
> We never used Data::Dumper in this script. The only reference
> of it was always commented out and removed over a decade ago in
> commit 4bc87a28be020a6bf7387161c65ea3d8e4a0228b
> ("send-email: Change from Mail::Sendmail to Net::SMTP")
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
> While I'm in the area...
>
> git-send-email.perl | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-06 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-06 20:25 [PATCH] send-email: do not load Data::Dumper Eric Wong
2016-04-06 21:07 ` Jonathan Nieder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).