From: Santiago Torres <santiago@nyu.edu>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c
Date: Wed, 6 Apr 2016 23:40:07 -0400 [thread overview]
Message-ID: <20160407034007.GC17848@LykOS> (raw)
In-Reply-To: <CAPig+cQ4n5j4Q-WF-0cd=2+5eSAaimh3A7La+8Fe9Ox4anjtBQ@mail.gmail.com>
> > v5 (this):
> > Added helpful feedback by Eric
> >
> > * Reordering of the patches, to avoid temporal inclusion of a regression
> > * Fix typos here and there.
> > * Review commit messages, as some weren't representative of what the patches
> > were doing anymore.
> > * Updated t7030 to include Peff's suggestion, and added a helped-by line here
> > as it was mostly Peff's code.
> > * Updated the error-handling/printing issues that were introduced when.
> > libifying the verify_tag function.
>
> This version is a more pleasant read, easier to digest and understand.
> All of my review comments were minor; nothing demanding a re-roll. As
> such, this version is:
>
> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
>
> If you do happen to re-roll based upon the review comments, feel free
> to add my Reviewed-by: (but not if you make larger changes).
Thanks! I'll add your and Junio's in another re-roll.
-Santiago.
next prev parent reply other threads:[~2016-04-07 3:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 16:07 [PATCH v5 0/6] tag: move PGP verification code to tag.c santiago
2016-04-05 16:07 ` [PATCH v5 1/6] builtin/verify-tag.c: Ignore SIGPIPE on gpg-interface santiago
2016-04-06 16:43 ` Junio C Hamano
2016-04-05 16:07 ` [PATCH v5 2/6] t7030-verify-tag: Adds validation for multiple tags santiago
2016-04-06 6:21 ` Eric Sunshine
2016-04-17 17:31 ` Santiago Torres
2016-04-17 18:19 ` Eric Sunshine
2016-04-17 18:38 ` Santiago Torres
2016-04-17 18:53 ` Eric Sunshine
2016-04-06 16:45 ` Junio C Hamano
2016-04-05 16:07 ` [PATCH v5 3/6] builtin/verify-tag: change variable name for readability santiago
2016-04-06 16:46 ` Junio C Hamano
2016-04-05 16:07 ` [PATCH v5 4/6] builtin/verify-tag: replace name argument with sha1 santiago
2016-04-06 6:56 ` Eric Sunshine
2016-04-06 16:27 ` Junio C Hamano
2016-04-07 3:38 ` Santiago Torres
2016-04-05 16:07 ` [PATCH v5 5/6] builtin/verify-tag: move verification code to tag.c santiago
2016-04-06 16:33 ` Junio C Hamano
2016-04-05 16:07 ` [PATCH v5 6/6] tag: use gpg_verify_function in tag -v call santiago
2016-04-06 7:09 ` Eric Sunshine
2016-04-05 16:44 ` [PATCH v5 0/6] tag: move PGP verification code to tag.c Santiago Torres
2016-04-06 7:18 ` Eric Sunshine
2016-04-07 3:40 ` Santiago Torres [this message]
2016-04-07 16:19 ` Eric Sunshine
2016-04-17 17:34 ` Santiago Torres
2016-04-17 18:14 ` Eric Sunshine
2016-04-06 16:39 ` Junio C Hamano
2016-04-07 3:33 ` Santiago Torres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407034007.GC17848@LykOS \
--to=santiago@nyu.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).