From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t Date: Thu, 7 Apr 2016 20:28:32 +0300 Message-ID: <20160407202631-mutt-send-email-mst@redhat.com> References: <1460042563-32741-1-git-send-email-mst@redhat.com> <1460042563-32741-2-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org, Christian Couder , Matthieu Moy To: Junio C Hamano X-From: git-owner@vger.kernel.org Thu Apr 07 19:29:06 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aoDjs-0004vf-AI for gcvg-git-2@plane.gmane.org; Thu, 07 Apr 2016 19:29:04 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756840AbcDGR2q (ORCPT ); Thu, 7 Apr 2016 13:28:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39407 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757193AbcDGR2h (ORCPT ); Thu, 7 Apr 2016 13:28:37 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2D1AAC0003FD; Thu, 7 Apr 2016 17:28:36 +0000 (UTC) Received: from redhat.com (vpn1-7-7.ams2.redhat.com [10.36.7.7]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id u37HSXkc019455; Thu, 7 Apr 2016 13:28:34 -0400 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Apr 07, 2016 at 09:55:29AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > Allow -t as a short-cut for --trailer. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > As I do not think interpret-trailers is meant to be end-user facing, > I am not sure I should be interested in this step. > > I am in principle OK with the later step that teaches a single > letter option to end-user facing "git am" that would be turned into > "--trailer" when it calls out to "interpret-trailers" (I haven't > checked if 't' is a sensible choice for that single letter option, > though). Does OPT_PASSTHRU_ARGV handle this transformation for me? > > builtin/interpret-trailers.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/builtin/interpret-trailers.c b/builtin/interpret-trailers.c > > index b99ae4b..18cf640 100644 > > --- a/builtin/interpret-trailers.c > > +++ b/builtin/interpret-trailers.c > > @@ -25,7 +25,7 @@ int cmd_interpret_trailers(int argc, const char **argv, const char *prefix) > > struct option options[] = { > > OPT_BOOL(0, "in-place", &in_place, N_("edit files in place")), > > OPT_BOOL(0, "trim-empty", &trim_empty, N_("trim empty trailers")), > > - OPT_STRING_LIST(0, "trailer", &trailers, N_("trailer"), > > + OPT_STRING_LIST('t', "trailer", &trailers, N_("trailer"), > > N_("trailer(s) to add")), > > OPT_END() > > };