From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: git interpret-trailers with multiple keys Date: Sun, 10 Apr 2016 20:43:01 +0300 Message-ID: <20160410203556-mutt-send-email-mst@redhat.com> References: <20160406191054-mutt-send-email-mst@redhat.com> <20160406201509-mutt-send-email-mst@redhat.com> <20160406212940-mutt-send-email-mst@redhat.com> <20160410182750-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Junio C Hamano , Matthieu Moy , git To: Christian Couder X-From: git-owner@vger.kernel.org Sun Apr 10 19:43:14 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1apJOB-0006tR-9E for gcvg-git-2@plane.gmane.org; Sun, 10 Apr 2016 19:43:11 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755660AbcDJRnG (ORCPT ); Sun, 10 Apr 2016 13:43:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57597 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754816AbcDJRnF (ORCPT ); Sun, 10 Apr 2016 13:43:05 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5B827DCE3; Sun, 10 Apr 2016 17:43:03 +0000 (UTC) Received: from redhat.com (vpn1-5-25.ams2.redhat.com [10.36.5.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id u3AHh11a000876; Sun, 10 Apr 2016 13:43:02 -0400 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, Apr 10, 2016 at 06:57:53PM +0200, Christian Couder wrote: > What I meant is that we could create new options called maybe > trailer.autocommands and trailer..autocommands that default to > 'true' and if 'false' the command would not be run automatically and > the corresponding trailer would not be added. I don't think it has to do with commands. For example, if we add "value" it should behave the same. So I think a better name is "ifnotlisted", with values "add" and "donothing". Thoughts? -- MST