From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Tom G. Christensen" <tgc@jupiterrise.com>,
Elia Pinto <gitter.spiros@gmail.com>,
git@vger.kernel.org
Subject: Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris
Date: Tue, 12 Apr 2016 13:22:47 -0400 [thread overview]
Message-ID: <20160412172247.GA2856@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqvb3mrcgj.fsf@gitster.mtv.corp.google.com>
On Tue, Apr 12, 2016 at 09:58:20AM -0700, Junio C Hamano wrote:
> > Looks good and is the minimal change. I kind of wonder if the example
> > would be more clear, though, as just:
> >
> > write_script .git/hooks/pre-commit <<-\EOF &&
> > exit 1
> > EOF
> > echo whatever >file1 &&
> > ...
> >
> > I don't think we ever actually need the pre-commit check to pass, as we
> > simply override it with --no-verify. But I dunno. Maybe people find it
> > easier to read with a pseudo-realistic example (it took me a minute to
> > realize the trailing whitespace in the content was important).
>
> I was mostly worried about closing the door for future enhancement
> where there are multiple commits to be replayed, some of which fail
> and others pass the test. Unconditional "exit 1" would have to be
> reverted when it happens.
Yeah, that's fair. It is at least trying to re-create a real-world
situation.
-Peff
prev parent reply other threads:[~2016-04-12 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 20:27 Hardcoded #!/bin/sh in t5532 causes problems on Solaris Tom G. Christensen
2016-04-09 21:04 ` Jeff King
2016-04-09 22:29 ` Tom G. Christensen
2016-04-09 22:37 ` Jeff King
2016-04-10 0:37 ` Junio C Hamano
2016-04-10 19:01 ` Junio C Hamano
2016-04-10 21:51 ` Eric Sunshine
2016-04-11 16:42 ` Junio C Hamano
2016-04-11 17:27 ` Jeff King
2016-04-11 17:32 ` Jeff King
2016-04-12 16:58 ` Junio C Hamano
2016-04-12 17:12 ` Junio C Hamano
2016-04-12 17:23 ` Jeff King
2016-04-12 17:22 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412172247.GA2856@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
--cc=tgc@jupiterrise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).