From: David Aguilar <davvid@gmail.com>
To: John Keeping <john@keeping.me.uk>
Cc: Nikola Forrrr <nforro@redhat.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] difftool/mergetool: make the form of yes/no questions consistent
Date: Tue, 12 Apr 2016 11:05:46 -0700 [thread overview]
Message-ID: <20160412180546.GA27558@gmail.com> (raw)
In-Reply-To: <20160412140119.GC11013@serenity.lan>
On Tue, Apr 12, 2016 at 03:01:19PM +0100, John Keeping wrote:
> On Tue, Apr 12, 2016 at 03:53:12PM +0200, Nikola Forrrr wrote:
> > On Tue, 2016-04-12 at 14:27 +0100, John Keeping wrote:
> > > I think the case in these two is correct as-is. The "Y" is capitalised
> > > because it is the default and will take effect if the user just presses
> > > ENTER.
> >
> > Thanks John, I'm aware of that. That's why the patch doesn't change
> > the case. Maybe I should have mention that explicitly in the commit
> > message.
>
> Sorry, I completely missed that. Your patch does in fact look good, so:
>
> Reviewed-by: John Keeping <john@keeping.me.uk>
>
> I think I was taken in by the commit message saying 'i.e. "Question
> [y/n]? "' and didn't examine the patch carefully enough. It might be
> better just to drop the example since it's obvious what the patch does.
Thanks for reviewing.
Acked-by: David Aguilar <davvid@gmail.com>
cheers,
--
David
next prev parent reply other threads:[~2016-04-12 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 12:59 [PATCH] difftool/mergetool: make the form of yes/no questions consistent Nikola Forró
2016-04-12 13:27 ` John Keeping
2016-04-12 13:53 ` Nikola Forró
2016-04-12 14:01 ` John Keeping
2016-04-12 18:05 ` David Aguilar [this message]
2016-04-12 16:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412180546.GA27558@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=nforro@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).