From: Jeff King <peff@peff.net>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v2] replace --edit: respect core.editor
Date: Wed, 20 Apr 2016 02:53:49 -0400 [thread overview]
Message-ID: <20160420065349.GA14490@sigill.intra.peff.net> (raw)
In-Reply-To: <a7b889d525f99fecfb9d4a890fd2a5d4bf3001e0.1461134258.git.johannes.schindelin@gmx.de>
On Wed, Apr 20, 2016 at 08:38:03AM +0200, Johannes Schindelin wrote:
> We simply need to read the config, is all.
>
> This fixes https://github.com/git-for-windows/git/issues/733
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Looks good to me. Thanks.
-Peff
next prev parent reply other threads:[~2016-04-20 6:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 14:37 [PATCH] replace --edit: respect core.editor Johannes Schindelin
2016-04-19 16:22 ` Junio C Hamano
2016-04-20 3:53 ` Jeff King
2016-04-20 5:51 ` Christian Couder
2016-04-20 6:37 ` Johannes Schindelin
2016-04-20 6:33 ` Johannes Schindelin
2016-04-20 15:26 ` Junio C Hamano
2016-04-20 6:38 ` [PATCH v2] " Johannes Schindelin
2016-04-20 6:53 ` Jeff King [this message]
2016-04-20 15:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420065349.GA14490@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).