From: Michael Weiser <michael@weiser.dinsnail.net>
To: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, David Abdurachmanov <David.Abdurachmanov@cern.ch>
Subject: Re: [PATCH] Extend runtime prefix computation
Date: Wed, 20 Apr 2016 19:52:07 +0200 [thread overview]
Message-ID: <20160420175207.GA28640@weiser.dinsnail.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1604180918500.2967@virtualbox> <xmqqfuumddqm.fsf@gitster.mtv.corp.google.com>
Hi,
On Fri, Apr 15, 2016 at 09:43:29AM -0700, Junio C Hamano wrote:
> We tend to avoid system specific includes in individual *.c files.
> Perhaps implement platform specific bits in compat/? E.g. each
> platform specific file in compat/ may implement and export the same
> git_extract_argv_path() function, perhaps, so that this file does
> not even need to know what platforms it supports?
On Mon, Apr 18, 2016 at 09:20:25AM +0200, Johannes Schindelin wrote:
> I have to admit that I am really, *really* skeptical. To me, it looks like
> this patch opens the door very wide to unintended consequences.
To make it short: I had received interest from another user for
relocatable git installations and an updated patch against current git
(based on my last post of the code to this list in 2012). This
confirmed to me that the use case is still valid. However, I do not see
myself in a position to iterate the code through the review and
improvement process that starting to unfold now. So if someone sometime
picks this up and carries on, I'd be happy. Otherwise please disregard.
--
Thanks,
Michael
next prev parent reply other threads:[~2016-04-20 19:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 14:30 [PATCH] Extend runtime prefix computation Michael Weiser
2016-04-15 16:43 ` Junio C Hamano
2016-04-18 7:20 ` Johannes Schindelin
2016-04-20 17:52 ` Michael Weiser [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-27 16:30 Michael Weiser
2012-11-30 10:20 ` Erik Faye-Lund
2012-11-30 10:45 ` Michael Weiser
2013-03-05 11:58 ` Michael Weiser
2013-03-05 16:13 ` Junio C Hamano
2013-03-06 8:19 ` Michael Weiser
2013-04-16 14:56 ` Michael Weiser
2013-04-16 18:23 ` Junio C Hamano
2013-04-16 15:18 ` Erik Faye-Lund
2013-04-17 6:06 ` Michael Weiser
2013-10-04 13:32 ` Michael Weiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420175207.GA28640@weiser.dinsnail.net \
--to=michael@weiser.dinsnail.net \
--cc=David.Abdurachmanov@cern.ch \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).