From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] test-lib: simplify '--option=value' parsing
Date: Fri, 22 Apr 2016 14:37:03 -0400 [thread overview]
Message-ID: <20160422183703.GA7595@sigill.intra.peff.net> (raw)
In-Reply-To: <1461339503-6854-1-git-send-email-szeder@ira.uka.de>
On Fri, Apr 22, 2016 at 05:38:23PM +0200, SZEDER Gábor wrote:
> To get the 'value' from '--option=value', test-lib.sh parses said
> option running 'expr' with a regexp. This involves a subshell, an
> external process, and a lot of non-alphanumeric characters in the
> regexp.
>
> Use a much simpler shell parameter expansion instead to do the same.
Looks OK to me. I doubt the extra process is a killer (we only parse
options once per script), but the result is definitely more readable,
IMHO.
For some reason I had always assumed that complicated pattern matching
with "#" was non-POSIX, but I checked and it is definitely in there.
> ---
> t/test-lib.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
I count 5 cases in my copy of test-lib.sh. I think you are missing
"--run".
-Peff
next prev parent reply other threads:[~2016-04-22 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 15:38 [PATCH] test-lib: simplify '--option=value' parsing SZEDER Gábor
2016-04-22 18:37 ` Jeff King [this message]
2016-04-22 20:32 ` [PATCH v2] " SZEDER Gábor
2016-04-22 20:54 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422183703.GA7595@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).