From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brian Norris <computersforpeace@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] http: expand http.cookieFile as a path
Date: Fri, 29 Apr 2016 13:56:51 -0400 [thread overview]
Message-ID: <20160429175651.GA30765@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq7ffgz4ej.fsf@gitster.mtv.corp.google.com>
On Fri, Apr 29, 2016 at 10:55:00AM -0700, Junio C Hamano wrote:
> Thanks. Perhaps squash this to the patch in the message you are
> responding to.
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index ff7eaaf..786e0fa 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> [...]
Yeah, this (and the rest of the plan you outlined) all look good to me.
Thanks.
-Peff
next prev parent reply other threads:[~2016-04-29 17:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 6:23 [PATCH 1/2] Documentation: config: improve word ordering for http.cookieFile Brian Norris
2016-04-29 6:23 ` [PATCH 2/2] http: expand http.cookieFile as a path Brian Norris
2016-04-29 14:12 ` Jeff King
2016-04-29 15:55 ` Brian Norris
2016-04-29 17:48 ` Junio C Hamano
2016-04-29 17:49 ` Jeff King
2016-04-29 17:55 ` Junio C Hamano
2016-04-29 17:56 ` Jeff King [this message]
2016-04-29 17:52 ` Junio C Hamano
2016-04-29 17:11 ` Junio C Hamano
2016-04-29 17:16 ` Jeff King
2016-04-29 17:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429175651.GA30765@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=computersforpeace@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).