From: Jeff King <peff@peff.net>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org, tboegi@web.de, ramsay@ramsayjones.plus.com,
gitster@pobox.com, sunshine@sunshineco.com
Subject: Re: [PATCHv5 1/2] http.c: implement the GIT_TRACE_CURL environment variable
Date: Mon, 2 May 2016 14:15:33 -0400 [thread overview]
Message-ID: <20160502181533.GC8439@sigill.intra.peff.net> (raw)
In-Reply-To: <20160502142813.50868-2-gitter.spiros@gmail.com>
On Mon, May 02, 2016 at 02:28:12PM +0000, Elia Pinto wrote:
> + if (nopriv &&
> + (skip_prefix(out.buf + prefix_len, "Authorization:", &header)
> + || skip_prefix(out.buf + prefix_len, "Proxy-Authorization:", &header))) {
> + /* The first token is the type, which is OK to log */
> + while (isspace(*header))
> + header++;
> + /* Everything else is opaque and possibly sensitive */
The first comment there is now misleading, as we _don't_ keep the first
token (though as mentioned elsewhere, I think we should).
> +void setup_curl_trace(CURL *handle)
> +{
> + if (!trace_want(&trace_curl)) return;
Style: we always put conditional bodies on a new line, even when they
are trivial like this.
-Peff
next prev parent reply other threads:[~2016-05-02 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 14:28 [PATCHv5 0/2] Implement the GIT_TRACE_CURL environment variable Elia Pinto
2016-05-02 14:28 ` [PATCHv5 1/2] http.c: implement " Elia Pinto
2016-05-02 17:03 ` Ramsay Jones
2016-05-02 18:15 ` Jeff King [this message]
2016-05-02 18:59 ` Junio C Hamano
2016-05-02 19:25 ` Jeff King
2016-05-02 19:15 ` Junio C Hamano
2016-05-02 14:28 ` [PATCHv5 2/2] imap-send.c: introduce " Elia Pinto
2016-05-02 18:13 ` [PATCHv5 0/2] Implement " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502181533.GC8439@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).