From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: gitster@pobox.com, git@vger.kernel.org, janx@linux.com
Subject: Re: [PATCH] t7300: mark test with SANITY
Date: Tue, 3 May 2016 15:04:17 -0400 [thread overview]
Message-ID: <20160503190417.GD30530@sigill.intra.peff.net> (raw)
In-Reply-To: <1462301672-20866-1-git-send-email-sbeller@google.com>
On Tue, May 03, 2016 at 11:54:32AM -0700, Stefan Beller wrote:
> As the test runs `chmod 0` on a file, we don't want to run that test
> as root.
This somehow misses the root (no pun intended) of the issue, to me.
Perhaps:
We `chmod 0` a file and test a case where git is unable to read it.
If the test is run as root, the permissions are ignored, and our
simulated read failure does not happen.
The patch itself looks obviously correct. :)
-Peff
next prev parent reply other threads:[~2016-05-03 19:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 18:54 [PATCH] t7300: mark test with SANITY Stefan Beller
2016-05-03 19:04 ` Jeff King [this message]
2016-05-03 19:09 ` Junio C Hamano
2016-05-03 19:28 ` Junio C Hamano
2016-05-03 21:15 ` Jeff King
2016-05-03 21:19 ` Junio C Hamano
2016-05-03 21:35 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503190417.GD30530@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=janx@linux.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).