From: Jeff King <peff@peff.net>
To: Li Peng <lip@dtdream.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] utf8: fix duplicate words of "the"
Date: Fri, 6 May 2016 09:09:22 -0400 [thread overview]
Message-ID: <20160506130922.GA5051@sigill.intra.peff.net> (raw)
In-Reply-To: <1462537893-18493-1-git-send-email-lip@dtdream.com>
On Fri, May 06, 2016 at 08:31:33PM +0800, Li Peng wrote:
> Fix duplicate words of "the" in comment.
Obviously a good change, along with the other one of mine you found.
> ---
> transport-helper.c | 2 +-
> utf8.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
You seem to be breaking these up by file; was the change in
transport-helper supposed to be in a different patch?
IMHO it would be fine to just do all of these in a single patch. They're
different files, yes, but it's all conceptually the same change.
-Peff
next prev parent reply other threads:[~2016-05-06 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 12:31 [PATCH] utf8: fix duplicate words of "the" Li Peng
2016-05-06 13:09 ` Jeff King [this message]
2016-05-06 17:28 ` Junio C Hamano
2016-05-06 18:30 ` Junio C Hamano
2016-05-07 15:10 ` 回复：[PATCH] " 李三0159
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506130922.GA5051@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=lip@dtdream.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).