From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Git List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Michael Rappazzo" <rappazzo@gmail.com>,
"Duy Nguyen" <pclouds@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Johannes Sixt" <j.sixt@viscovery.net>
Subject: Re: [PATCH 5/6] t1500: avoid setting environment variables outside of tests
Date: Tue, 10 May 2016 16:41:59 -0400 [thread overview]
Message-ID: <20160510204159.GA19958@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cQ0jEt10p--K8jNrFBi21PkmFXuHpUPewuOWrpx+3Ma7g@mail.gmail.com>
On Tue, May 10, 2016 at 03:59:42PM -0400, Eric Sunshine wrote:
> On Tue, May 10, 2016 at 3:48 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> > Actually, I think we can have improved encapsulation and maintain
> > readability like this:
> >
> > case "$1" in
> > ...
> > -g) env="$2"; shift; shift ;;
> > ...
> > esac
> >
> > ...
> > test_expect_success "..." '
> > if test -n "$env"
> > do
> > test_when_finished "unset GIT_DIR"
> > GIT_DIR="$env"
> > export GIT_DIR
> > fi
> > ...
> > '
>
> At this point, I'd also rename 'env' to 'gitdir' to be more meaningful.
Yeah, I like this even better. As much as I enjoy eval tricks, I think
this case is more readable with the condition written out.
-Peff
next prev parent reply other threads:[~2016-05-10 20:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 5:20 [PATCH 0/6] modernize t1500 Eric Sunshine
2016-05-10 5:20 ` [PATCH 1/6] t1500: test_rev_parse: facilitate future test enhancements Eric Sunshine
2016-05-10 5:20 ` [PATCH 2/6] t1500: reduce dependence upon global state Eric Sunshine
2016-05-10 5:20 ` [PATCH 3/6] t1500: avoid changing working directory outside of tests Eric Sunshine
2016-05-10 5:20 ` [PATCH 4/6] t1500: avoid setting configuration options " Eric Sunshine
2016-05-10 6:34 ` Eric Sunshine
2016-05-10 18:02 ` Junio C Hamano
2016-05-10 5:20 ` [PATCH 5/6] t1500: avoid setting environment variables " Eric Sunshine
2016-05-10 18:39 ` Jeff King
2016-05-10 19:12 ` Eric Sunshine
2016-05-10 19:19 ` Junio C Hamano
2016-05-10 19:48 ` Eric Sunshine
2016-05-10 19:59 ` Eric Sunshine
2016-05-10 20:41 ` Jeff King [this message]
2016-05-10 20:07 ` Junio C Hamano
2016-05-10 21:01 ` SZEDER Gábor
2016-05-10 21:11 ` Junio C Hamano
2016-05-10 21:19 ` Eric Sunshine
2016-05-10 5:20 ` [PATCH 6/6] t1500: be considerate to future potential tests Eric Sunshine
2016-05-10 6:07 ` [PATCH 0/6] modernize t1500 Junio C Hamano
2016-05-10 18:10 ` Junio C Hamano
2016-05-10 18:26 ` Junio C Hamano
2016-05-16 17:39 ` Eric Sunshine
2016-05-16 18:52 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2016-02-29 6:30 50a6c8ef - xmalloc_array Torsten Bögershausen
2016-02-29 9:28 ` [PATCH] compat/mingw: brown paper bag fix for 50a6c8e Jeff King
2016-02-29 9:56 ` Torsten Bögershausen
2016-02-29 10:02 ` Jeff King
2016-02-29 10:40 ` Compiler warning under cygwin/mingw (was: fix for 50a6c8e) Torsten Bögershausen
2016-02-29 10:47 ` Jeff King
2016-02-29 14:05 ` SZEDER Gábor
2016-04-12 23:20 ` Compiler warning under cygwin/mingw Junio C Hamano
2016-05-10 18:29 ` [PATCH 0/6] modernize t1500 Junio C Hamano
2016-02-29 12:32 ` Compiler warning under cygwin/mingw Ramsay Jones
2016-03-03 3:33 ` Ramsay Jones
2016-03-03 5:25 ` Ramsay Jones
2016-02-29 19:10 ` [PATCH] compat/mingw: brown paper bag fix for 50a6c8e Junio C Hamano
2016-02-29 21:36 ` Jeff King
2016-03-01 5:49 ` Torsten Bögershausen
2016-03-01 5:54 ` Jeff King
2016-03-01 13:52 ` Johannes Schindelin
2016-02-29 13:01 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510204159.GA19958@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=pclouds@gmail.com \
--cc=rappazzo@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).