From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 1/2] am: plug small memory leak when split_mail_stgit_series() fails
Date: Wed, 11 May 2016 16:35:45 -0700 [thread overview]
Message-ID: <20160511233546.13090-1-gitster@pobox.com> (raw)
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin/am.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/builtin/am.c b/builtin/am.c
index ec75906..f1a84c6 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -842,9 +842,11 @@ static int split_mail_stgit_series(struct am_state *state, const char **paths,
series_dir = dirname(series_dir_buf);
fp = fopen(*paths, "r");
- if (!fp)
+ if (!fp) {
+ free(series_dir_buf);
return error(_("could not open '%s' for reading: %s"), *paths,
strerror(errno));
+ }
while (!strbuf_getline(&sb, fp, '\n')) {
if (*sb.buf == '#')
--
2.8.2-679-g91c6421
next reply other threads:[~2016-05-11 23:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 23:35 Junio C Hamano [this message]
2016-05-11 23:35 ` [PATCH 2/2] am: plug FILE * leak in split_mail_conv() Junio C Hamano
2016-05-12 4:47 ` Jeff King
2016-05-12 5:23 ` Mikael Magnusson
2016-05-12 5:29 ` Jeff King
2016-05-12 7:59 ` Eric Wong
2016-05-12 8:03 ` Jeff King
2016-05-12 15:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511233546.13090-1-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).