From: Joey Hess <id@joeyh.name>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: proposal for extending smudge/clean filters with raw file access
Date: Thu, 12 May 2016 17:02:27 -0400 [thread overview]
Message-ID: <20160512210227.GA10786@kitenet.net> (raw)
In-Reply-To: <xmqqvb2jf6dg.fsf@gitster.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
Junio C Hamano wrote:
> The smudge happens to be the last to run, so it is quite true that
> it can say "Hey Git, I've written it out already".
>
> I didn't check all codepaths to ensure that we won't need the
> smudged result in core at all, but I am guessing you did so before
> making this proposal, so in that case I would say this sounds fine.
Well, the idea is to only use smudge-to-file when the smudged content is
going to be written out to a file. Any other code paths that need to
smudge some content would use the smudge filter.
So, try_create_file would use it. Maybe some other places I have not
found yet could as well.
--
see shy jo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2016-05-12 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 18:24 proposal for extending smudge/clean filters with raw file access Joey Hess
2016-05-12 19:01 ` Junio C Hamano
2016-05-12 21:02 ` Joey Hess [this message]
2016-05-12 20:14 ` Junio C Hamano
2016-05-12 20:46 ` Joey Hess
2016-05-12 20:55 ` Junio C Hamano
2016-05-12 21:17 ` Joey Hess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512210227.GA10786@kitenet.net \
--to=id@joeyh.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).