git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Beller <sbeller@google.com>
To: jrnieder@gmail.com
Cc: git@vger.kernel.org, Stefan Beller <stefanbeller@gmail.com>,
	Stefan Beller <sbeller@google.com>
Subject: [PATCH 2/3] pack-redundant: free all memory
Date: Mon, 16 May 2016 20:22:46 -0700	[thread overview]
Message-ID: <20160517032247.25092-3-sbeller@google.com> (raw)
In-Reply-To: <20160517032247.25092-1-sbeller@google.com>

From: Stefan Beller <stefanbeller@gmail.com>

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 builtin/pack-redundant.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/builtin/pack-redundant.c b/builtin/pack-redundant.c
index 72c8158..c75c5c9 100644
--- a/builtin/pack-redundant.c
+++ b/builtin/pack-redundant.c
@@ -223,6 +223,18 @@ static inline size_t pack_list_size(struct pack_list *pl)
 	return ret;
 }
 
+static inline void pack_list_free(struct pack_list *pl)
+{
+	struct pack_list *cur_pl;
+	while (pl) {
+		llist_free(pl->unique_objects);
+		llist_free(pl->all_objects);
+		cur_pl = pl;
+		pl = pl->next;
+		free(cur_pl);
+	}
+}
+
 static struct pack_list * pack_list_difference(const struct pack_list *A,
 					       const struct pack_list *B)
 {
@@ -691,5 +703,10 @@ int cmd_pack_redundant(int argc, const char **argv, const char *prefix)
 		fprintf(stderr, "%luMB of redundant packs in total.\n",
 			(unsigned long)pack_set_bytecount(red)/(1024*1024));
 
+#ifdef FREE_ALL_MEMORY
+	pack_list_free(red);
+	llist_free(ignore);
+#endif
+
 	return 0;
 }
-- 
2.8.2.401.g9c0faef

  parent reply	other threads:[~2016-05-17  3:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17  3:22 [RFD PATCH 0/3] Free all the memory! Stefan Beller
2016-05-17  3:22 ` [PATCH 1/3] mv: free memory at the end if desired Stefan Beller
2016-05-17  4:14   ` Torsten Bögershausen
2016-05-17  3:22 ` Stefan Beller [this message]
2016-05-17  3:42   ` [PATCH 2/3] pack-redundant: free all memory Eric Sunshine
2016-05-17  3:22 ` [PATCH 3/3] rev-parse: " Stefan Beller
2016-05-17  3:41 ` [RFD PATCH 0/3] Free all the memory! Eric Sunshine
2016-05-17 12:08   ` Eric Wong
2016-05-17 17:58   ` Stefan Beller
2016-05-17 18:16     ` Junio C Hamano
2016-05-17 18:20       ` Stefan Beller
2016-05-18  7:23     ` Eric Wong
2016-05-18 15:19     ` Ævar Arnfjörð Bjarmason
2016-05-17  5:46 ` David Turner
2016-05-17  9:05 ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160517032247.25092-3-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=stefanbeller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).