From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"Michael Rappazzo" <rappazzo@gmail.com>,
"Duy Nguyen" <pclouds@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Johannes Sixt" <j.sixt@viscovery.net>
Subject: Re: [PATCH v2 3/5] t1500: avoid changing working directory outside of tests
Date: Tue, 17 May 2016 17:52:14 -0400 [thread overview]
Message-ID: <20160517215214.GA16905@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cTAgB6DXoEeJaDVy7_J7QiqNOm6AJqZTiSowO6_jqa8_w@mail.gmail.com>
On Tue, May 17, 2016 at 04:48:33PM -0400, Eric Sunshine wrote:
> On Tue, May 17, 2016 at 4:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > Eric Sunshine <sunshine@sunshineco.com> writes:
> >> + git ${dir:+-C "$dir"} rev-parse --$o >actual &&
> >
> > This is kosher POSIX, but I vaguely recall some shells had trouble
> > with the SP between -C and "$dir" in the past. Let's see if anybody
> > screams; hopefully I am misremembering or buggy shells died out.
>
> I also am bothered by a vague recollection of some issue (possibly
> involving the internal space and lack of quotes around the entire
> ${...}), but couldn't remember nor find a reference to the specific
> details. Perhaps someone reading the patch has a better memory than I.
Probably:
http://thread.gmane.org/gmane.comp.version-control.git/265094
-Peff
next prev parent reply other threads:[~2016-05-17 21:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 19:36 [PATCH v2 0/5] modernize t1500 Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 1/5] t1500: be considerate to future potential tests Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 2/5] t1500: test_rev_parse: facilitate future test enhancements Eric Sunshine
2016-05-18 16:38 ` SZEDER Gábor
2016-05-18 17:32 ` Eric Sunshine
2016-05-18 17:43 ` Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 3/5] t1500: avoid changing working directory outside of tests Eric Sunshine
2016-05-17 20:37 ` Junio C Hamano
2016-05-17 20:48 ` Eric Sunshine
2016-05-17 21:52 ` Jeff King [this message]
2016-05-17 22:48 ` Eric Sunshine
2016-05-17 22:48 ` Junio C Hamano
2016-05-17 23:06 ` SZEDER Gábor
2016-05-18 3:33 ` Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 4/5] t1500: avoid setting configuration options " Eric Sunshine
2016-05-17 19:36 ` [PATCH v2 5/5] t1500: avoid setting environment variables " Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517215214.GA16905@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=pclouds@gmail.com \
--cc=rappazzo@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).