git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: JP Sugarbroad <jpsugar@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: git fetch origin $SHA1 doesn't work as often as it could
Date: Wed, 18 May 2016 21:53:23 -0400	[thread overview]
Message-ID: <20160519015323.GA24225@sigill.intra.peff.net> (raw)
In-Reply-To: <CAD0oC4wezb8svOW5KHONLi5wQN+H_3xqPLoU_EZbtL5zAkdv_Q@mail.gmail.com>

On Wed, May 18, 2016 at 06:40:37PM -0400, JP Sugarbroad wrote:

> > I just fear that it is a wrong approach to solve the real issue and
> > instead make it worse by relieving the pressure from the project and
> > hosting site to configure their repository to support their users
> > properly.
> 
> Unfortunately I don't see the likes of github or bitbucket adding
> allow-reachable-sha1-in-want any time soon, as it is an expensive
> operation server-side.

I don't think it's _too_ bad, at least compared to some of the nastier
things one can convince the server side of a git fetch to do. It at
least looks at just the commits; the bad cases usually involve
traversing the whole object graph.

It's also something that's easily sped up with reachability bitmaps.

But I haven't done any real analysis on the kind of load it would cause.
So no promises, but I don't think it's outside the realm of possibility
for GitHub to enable, if it's something that would be useful to a lot of
people. I can't speak for Bitbucket. :)

-Peff

      reply	other threads:[~2016-05-19  1:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 20:20 git fetch origin $SHA1 doesn't work as often as it could JP Sugarbroad
2016-05-18 21:59 ` Junio C Hamano
2016-05-18 22:40   ` JP Sugarbroad
2016-05-19  1:53     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160519015323.GA24225@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jpsugar@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).