From: Mike Hommey <mh@glandium.org>
To: Michael Rappazzo <rappazzo@gmail.com>
Cc: git@vger.kernel.org, pclouds@gmail.com, gitster@pobox.com
Subject: Re: [PATCH] rev-parse: fix --git-common-dir when executed from subpath of main tree
Date: Thu, 19 May 2016 17:50:49 +0900 [thread overview]
Message-ID: <20160519085049.GA26914@glandium.org> (raw)
In-Reply-To: <1459734143-95832-1-git-send-email-rappazzo@gmail.com>
On Sun, Apr 03, 2016 at 09:42:23PM -0400, Michael Rappazzo wrote:
> Executing `git-rev-parse --git-common-dir` from the root of the main
> worktree results in '.git', which is the relative path to the git dir.
> When executed from a subpath of the main tree it returned somthing like:
> 'sub/path/.git'. Change this to return the proper relative path to the
> git directory (similar to `--show-cdup`).
Note that `git rev-parse --git-dir` returns an absolute path, not a
relative one. Shouldn't --git-common-dir "simply" return the same as
--git-dir when not in a worktree?
Mike
prev parent reply other threads:[~2016-05-19 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 1:42 [PATCH] rev-parse: fix --git-common-dir when executed from subpath of main tree Michael Rappazzo
2016-04-04 6:01 ` Eric Sunshine
2016-04-08 11:47 ` Duy Nguyen
2016-04-08 12:35 ` Mike Rappazzo
2016-05-19 7:49 ` Mike Hommey
2016-05-19 14:15 ` Mike Rappazzo
2016-05-19 8:50 ` Mike Hommey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519085049.GA26914@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=rappazzo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).