From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, tboegi@web.de
Subject: Re: [PATCH v6 1/9] connect: call get_host_and_port() earlier
Date: Sat, 21 May 2016 07:28:31 +0900 [thread overview]
Message-ID: <20160520222831.GA7752@glandium.org> (raw)
In-Reply-To: <xmqqwpmobcd4.fsf@gitster.mtv.corp.google.com>
On Fri, May 20, 2016 at 03:20:23PM -0700, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> >> Can never happen because?
> >>
> >> !*port means get_host_and_port() made the "port" pointer point at
> >> a NUL byte. That does not happen because the only case port is
> >> moved by that function is to have it point at a byte after we
> >> found ':', and the "port" string is a decimal integer whose value
> >> is between 0 and 65535, so there is no way port points at an empty
> >> string.
> >>
> >> OK.
> >
> > Do you want me to add this to the commit message in a possible v7?
>
> No.
>
> I was merely thinking aloud to see if "in a case that never can
> happen" is sufficient decsription. I think it is ;-)
>
> >> This looks strange....
> > v3 of this series did remove this get_port(), and broke the
> > '[host:port]:path' syntax as a consequence. The reason this happens is
> > that get_host_and_port, in that case, is called with [host:port], sees
> > the square brackets, and searches the port *after* the closing bracket,
> > because the usual case where square brackets appear is ipv6 addresses,
> > which contain colons, and the brackets in that case are used to separate
> > the host and the port.
> >
> > In that case, get_host_and_port returns "host:port" and null.
>
> Doesn't that indicate that this codepath deserves some in-code
> comment?
What would be the usual way you'd do this? separate patch? or just doing
it in one of the patches that touches the surrounding code?
Mike
next prev parent reply other threads:[~2016-05-20 22:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 1:35 [PATCH v6 0/9] connect: various cleanups Mike Hommey
2016-05-17 1:35 ` [PATCH v6 1/9] connect: call get_host_and_port() earlier Mike Hommey
2016-05-20 20:58 ` Junio C Hamano
2016-05-20 22:14 ` Mike Hommey
2016-05-20 22:20 ` Junio C Hamano
2016-05-20 22:28 ` Mike Hommey [this message]
2016-05-17 1:35 ` [PATCH v6 2/9] connect: only match the host with core.gitProxy Mike Hommey
2016-05-20 21:48 ` Junio C Hamano
2016-05-20 22:30 ` Mike Hommey
2016-05-20 22:56 ` Junio C Hamano
2016-05-17 1:35 ` [PATCH v6 3/9] connect: fill the host header in the git protocol with the host and port variables Mike Hommey
2016-05-17 1:35 ` [PATCH v6 4/9] connect: make parse_connect_url() return separated host and port Mike Hommey
2016-05-17 1:35 ` [PATCH v6 5/9] connect: group CONNECT_DIAG_URL handling code Mike Hommey
2016-05-17 1:35 ` [PATCH v6 6/9] connect: make parse_connect_url() return the user part of the url as a separate value Mike Hommey
2016-05-17 1:35 ` [PATCH v6 7/9] connect: change the --diag-url output to separate user and host Mike Hommey
2016-05-17 1:35 ` [PATCH v6 8/9] connect: actively reject git:// urls with a user part Mike Hommey
2016-05-17 1:35 ` [PATCH v6 9/9] connect: move ssh command line preparation to a separate function Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520222831.GA7752@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).